Convert tool tip components to TypeScript#2013
Merged
pugnascotia merged 4 commits intoelastic:masterfrom Jun 10, 2019
Merged
Conversation
pugnascotia
commented
Jun 8, 2019
pugnascotia
commented
Jun 8, 2019
chandlerprall
approved these changes
Jun 10, 2019
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
All updates LGTM, confirmed docs still work as expected. Requesting that one comment is removed, but don't want to block merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Convert tool tip components to TypeScript. I checked that the build still works and that the examples in the docs still operate.
Checklist