[babel] remove @babel/polyfill, make core-js devDep#1982
Merged
spalger merged 9 commits intoelastic:masterfrom Jun 7, 2019
spalger:remove-core-js-prod
Merged
[babel] remove @babel/polyfill, make core-js devDep#1982spalger merged 9 commits intoelastic:masterfrom spalger:remove-core-js-prod
spalger merged 9 commits intoelastic:masterfrom
spalger:remove-core-js-prod
Conversation
Merged
1 task
chandlerprall
suggested changes
Jun 3, 2019
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
One last change, otherwise everything looks good in the various cases I've put the this through.
Contributor
|
CI had an http timeout jenkins test this |
chandlerprall
approved these changes
Jun 3, 2019
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM; ran build locally and verified core-js imports are removed as desired, and builds continue to run as expected.
Contributor
|
CI looks like its hanging again, but let's hold merging this until EUI@11.3.0 is released regardless |
thompsongl
suggested changes
Jun 4, 2019
thompsongl
approved these changes
Jun 6, 2019
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
CL in its right place
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It feels like we shouldn't be requiring core-js in eui, and should instead rely on the application to setup a polyfill that modifies globals. To do this i've followed the pattern used for customizing the babel es module config and disabled the
uiBuiltIns: usageconfig when building for production.This means that consumers of EUI need to use a polyfill of some sort (preferably core-js@3), which is why I've labeled this a breaking change, but in reality every consumer of eui should already be doing this it just wasn't explicitly required before.
Checklist
Any props added have proper autodocsDocumentation examples were addedJest tests were updated or added to match the most common scenariosThis was checked against keyboard-only and screenreader scenariosThis required updates to Framer X components