Adds alignment, distribution, and position icons#2070
Adds alignment, distribution, and position icons#2070ryankeairns merged 1 commit intoelastic:masterfrom
Conversation
9a75ebb to
4383158
Compare
|
This is great! What are your thoughts on making a few of these icon names a little more succinct. Examples:
Since you're already appending |
|
Somewhat unfortunately, we already have We could remove the word Position, but I like that it keeps the pattern (and the order) similar to the others (Align, Distribute). I agree they are a little long, but there is some necessity along with organizational and consistency benefits. |
|
Would it help to shorten Distribute and Position to Dist and Pos? |
cchaos
left a comment
There was a problem hiding this comment.
Ahh yeah, I didn't realize we were already using the aligns for text alignment. We really kind of pigeon holed ourselves on that one. Then I think the names you have are good and will be easier to expand up on in the future.
Fixes #2067
Summary
EuiIconpopoutglyphNote: Used a naming patter of
editorItemAlign*since 1) there are alreadyeditorAlign*icons and 2) to avoid the order from getting all jumbled.Preview
Sketch pixel grid
Checklist
This was checked in mobileThis was checked in IE11Any props added have proper autodocsThis was checked for breaking changes and labeled appropriatelyJest tests were updated or added to match the most common scenariosThis was checked against keyboard-only and screenreader scenariosThis required updates to Framer X components