Allow sorting by computed columns in EuiInMemoryTable#2044
Merged
chandlerprall merged 11 commits intoelastic:masterfrom Jun 18, 2019
Merged
Allow sorting by computed columns in EuiInMemoryTable#2044chandlerprall merged 11 commits intoelastic:masterfrom
chandlerprall merged 11 commits intoelastic:masterfrom
Conversation
pugnascotia
reviewed
Jun 17, 2019
src-docs/src/views/tables/in_memory/in_memory_custom_sorting.js
Outdated
Show resolved
Hide resolved
pugnascotia
reviewed
Jun 17, 2019
pugnascotia
reviewed
Jun 17, 2019
Co-Authored-By: Rory Hunter <pugnascotia@users.noreply.github.com>
chrisronline
approved these changes
Jun 17, 2019
Contributor
chrisronline
left a comment
chrisronline
left a comment
There was a problem hiding this comment.
I pulled this down, built it locally, copied the files over to my local Kibana, and tried it out and it works great! LGTM!
Contributor
Author
|
@pugnascotia applied your suggestions, definitely like testing against the explicit values! |
pugnascotia
approved these changes
Jun 17, 2019
Contributor
Author
|
jenkins test this |
1 similar comment
Contributor
Author
|
jenkins test this |
2 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2012.
Previously the actively sorted column was tracked by the column's
fieldvalue. In computed columns there is nofield. This PR changes the tracking to usename, and updatesEuiInMemoryTableandEuiBasicTableto accept the target column'sfieldorname, providing backwards compatibility.I've updated one existing unit test so it actually tests something, and have added four more unit tests to cover the new sort case and check two forms of backwards compatibility. Updated the In-Memory Table - Custom sort values docs section with an example of sorting by a computed field.
Checklist
- [ ] This was checked in mobile- [ ] This was checked in IE11- [ ] This was checked in dark mode- [ ] This was checked against keyboard-only and screenreader scenarios- [ ] This required updates to Framer X components