Added a fully black color variable $euiColorInk#2060
Merged
cchaos merged 2 commits intoelastic:masterfrom Jun 19, 2019
Merged
Conversation
Contributor
Author
|
Oh and I called it |
Contributor
|
Cool, so these are the always white/black variables unaffected by theme, right? |
Contributor
|
Duh, just read the changelog. |
ryankeairns
approved these changes
Jun 19, 2019
Contributor
ryankeairns
left a comment
ryankeairns
left a comment
There was a problem hiding this comment.
👍 LGTM. Little improvements like this are the best!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm tired of not having a black equivalent to
$euiColorGhostso here its.I also changed instances of
#000to use the new variable.Checklist
[ ] This was checked in mobile[ ] This was checked in IE11[ ] Any props added have proper autodocs[ ] This was checked for breaking changes and labeled appropriately[ ] Jest tests were updated or added to match the most common scenarios[ ] This was checked against keyboard-only and screenreader scenarios[ ] This required updates to Framer X components