Convert badge and token components to TypeScript#2026
Merged
pugnascotia merged 9 commits intoelastic:masterfrom Jun 11, 2019
Merged
Convert badge and token components to TypeScript#2026pugnascotia merged 9 commits intoelastic:masterfrom
pugnascotia merged 9 commits intoelastic:masterfrom
Conversation
Contributor
Author
|
jenkins test this |
chandlerprall
suggested changes
Jun 11, 2019
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
More structured TS definitions for the props; should be able to change the errors to console.warn to better mimic proptypes when the consuming application isn't using Typescript.
chandlerprall
suggested changes
Jun 11, 2019
| HTMLAttributes<HTMLSpanElement> & | ||
| BadgeProps; | ||
|
|
||
| export const EuiBetaBadge: FunctionComponent<EuiBetaBadeProps> = ({ |
Contributor
There was a problem hiding this comment.
typo, EuiBetaBadeProps -> EuiBetaBadgeProps
CHANGELOG.md
Outdated
| - Convert observer utility components to TypeScript ([#2009](https://github.com/elastic/eui/pull/2009)) | ||
| - Convert tool tip components to TypeScript ([#2013](https://github.com/elastic/eui/pull/2013)) | ||
|
|
||
| **Breaking changes** |
Contributor
There was a problem hiding this comment.
remove the breaking changes label
chandlerprall
approved these changes
Jun 11, 2019
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM; built locally and confirmed eui.d.ts is as expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Convert the badge and token components to TypeScript.
Note that
EuiBadgewas using prop type validation to check that ARIA labels were being supplied along with other props. Having converted the component to TS, this check now throws an error when it fails, with the intent being to catch this problem during development. Let me know if you think this is over-zealous (as I half-feel it might be).The same is true for
EuiBetaBadgewhen used without a tooltip - since in this case atitleattribute is added to the<span>that is rendered, the attribute value must be a string. The component now forcefully checks this.I also ended up converting the prop type utils. I'm less certain of what I've done here, so feedback welcome.
Checklist