Strip TS type exports even when they are being renamed#2069
Merged
chandlerprall merged 2 commits intoelastic:masterfrom Jun 20, 2019
Merged
Strip TS type exports even when they are being renamed#2069chandlerprall merged 2 commits intoelastic:masterfrom
chandlerprall merged 2 commits intoelastic:masterfrom
Conversation
thompsongl
approved these changes
Jun 20, 2019
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
Confirmed the expected output with local build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleans up renamed exports of TS types, such as Toast as EuiGlobalToastListToast, in toast/index.ts. There were two instances of the same bug, where the value being exported was observed instead of the local variable name.
After applying the fix & re-running babel on toast/index.ts the new output is
I also ran
icon/index.tsto confirm this did not affect the existing type removal when the variable is not renamed.Checklist
- [ ] This was checked in mobile- [ ] This was checked in IE11- [ ] This was checked in dark mode- [ ] Any props added have proper autodocs- [ ] Documentation examples were added- [ ] This was checked against keyboard-only and screenreader scenarios- [ ] This required updates to Framer X components