Convert observer utility components to TypeScript#2009
Merged
pugnascotia merged 1 commit intoelastic:masterfrom Jun 7, 2019
Merged
Convert observer utility components to TypeScript#2009pugnascotia merged 1 commit intoelastic:masterfrom
pugnascotia merged 1 commit intoelastic:masterfrom
Conversation
chandlerprall
approved these changes
Jun 7, 2019
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
LGTM! Pulled and built TS defs locally, confirmed the observers are still exported as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Convert the observer utility components to TypeScript. I added a dependency on
@types/resize-observer-browsersinceResizeObserverdoesn't appear to be supported in TypeScript yet.I checked that the examples in the docs site still worked in Chrome.
I also fixed a bug where the prop-types Babel plugin would bail on components with no props e.g.
Checklist