Fix Flyout scrolling in Safari#2033
Merged
Kerry350 merged 3 commits intoelastic:masterfrom Jun 13, 2019
Merged
Conversation
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
Contributor
Author
|
@cchaos Thanks for the review 🤘 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This issue was originally picked up in the Logs UI. The changes here allow the body of the Flyout component to scroll in Safari, currently in
masterit won't scroll at all. My understanding is that, according to the Flebox spec, forheightto take effect it needs to be present throughout the whole Flex hierarchy (so Safari was doing the right thing 😭).However, these changes do seem to introduce the classic body scrolling issue, which on
mastercurrently only exists in IE11. By body scrolling issue I mean that when the scrollable area of the flyout is exhausted the body will start to scroll. In the past I've generally solved this with anoscrollclass on thebodywhen the component is open, or hovered (depending on the scenario). Do EUI have a standard way of handling this?(Aside: there will also be a Kibana PR to update the legacy style for
.header-global-wrapper + .app-wrapper:not(.hidden-chrome) .euiFlyout, I'll open that once this PR is merged.).Checklist