Convert EuiCopy component to TypeScript#2016
Conversation
|
Thanks @scottybollinger ! As mentioned in Slack, we are in the process of actually converting the components to true TS instead of adding the TS defs as a shim. We can absolutely proceed with reviewing this PR as is unless you want to take a stab at converting to TS? |
|
@cchaos I went ahead and converted it and updated the title and description of the PR. Let me know if you need anything else! |
src/components/copy/copy.tsx
Outdated
| /** | ||
| * Tooltip message displayed before copy function is called. | ||
| */ | ||
| beforeMessage: ReactNode; |
There was a problem hiding this comment.
this prop is optional, please update the interface to match: beforeMessage?: ReactNode;
There was a problem hiding this comment.
Thanks @chandlerprall. Just to be sure, is there an associated defaultProps value for this as well?
There was a problem hiding this comment.
No, there is not (thanks for double checking!) - it's allowed to be null and in that case nothing is rendered.
Summary
Convert
EuiCopycomponent to TypeScript.Checklist