Merged
Conversation
7c39adc to
1178843
Compare
ryankeairns
approved these changes
Jun 19, 2019
src/components/form/form_control_layout/_form_control_layout.scss
Outdated
Show resolved
Hide resolved
Contributor
|
jenkins test this |
Contributor
Author
I think that is a different concern which involves: "How do we handle form rows with readOnly inputs" since there is no The lines below show how the example is created which is just passing a eui/src-docs/src/views/form_controls/form_control_layout.js Lines 95 to 97 in 57a866e I'll leave that for another day 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

While working on #2049, I noticed that we don't currently account for the readonly state when using prepend/append.
This PR, passes the
readOnlyto the EuiFormControlLayout and applies the correct styling. This means also having to explicitly state and use it as a prop for EuiFieldNumber, EuiFieldText, and EuiSelect. These are also the only ones that currently support prepend/append.Before

After

Checklist
[ ] This was checked for breaking changes and labeled appropriately[ ] This was checked against keyboard-only and screenreader scenarios[ ] This required updates to Framer X components