Persist provider name and model config in the session #5419

wpfleger96 · 2025-10-28T20:18:06Z

Summary

Building off #5399, this PR enables provider name/model config persistence by storing the configs in the Session struct. Now if a user resumes a previous session with --resume, the previous session's provider and model config will be automatically reloaded instead of defaulting to the provider/model from global config.

Type of Change

Testing

Manually tested

Related Issues

Fixes #5358

* main: fix: corrected my name in data (#5414) feat: add goose powered ai culinary innovation studio prompt to library (#5423) removing golang/temporal building testing tetrate with sonnet (#5428) Add Recipes Test Script (#5420) Don't die on strange chars (#5415) fix: allow subagent to run in parent --no-session mode (#5384) docs: analyze tool (#5418) fix: gracefully close goosed listening port (#5321) move history txt to state dir (#5410)

* main: (85 commits) improve linux tray icon support (#5425) feat: log rotation (#5561) use app.isPackaged instead of checking for node env development (#5465) disable RPM build-ID generation to prevent package conflicts (#5563) Add Diagnostics Info to Q&A and Bug Report Templates (#5565) fix: improve server error messages to include HTTP status code (#5532) improvement: add useful error message when attempting to use unauthenticated cursor-agent (#5300) fix: unblock acp via databricks (#5562) feat: add --output-format json flag to goose run command (#5525) Sessions required (#5548) feat: add grouped extension loading notification (#5529) we should run this on main and also test open models at least via ope… (#5556) info: print location of sessions.db via goose info (#5557) chore: remove yarn usage from documentation (#5555) cli: adjust default theme to address #1905 (#5552) Manual compaction counting fix + cli cleanup (#5480) chore(deps): bump prismjs and react-syntax-highlighter in /ui/desktop (#5549) fix: remove qwen3-coder from provider/mcp smoke tests (#5551) fix: do not build unsigned desktop app bundles on every PR in ci. add manual option. (#5550) fix: update Husky prepare script to v9 format (#5522) ...

Copilot

Pull Request Overview

This PR adds support for persisting provider and model configuration information to sessions in the database. When a provider is set on an agent, its configuration (provider name and model config) is now saved to the session record, allowing sessions to remember and restore their provider settings.

Key changes:

Added provider_name and model_config fields to the Session struct and database schema
Introduced persist_provider_config() method on Agent to save provider configuration to sessions
Updated session resume logic to restore saved provider/model settings
Schema version bumped from 5 to 6 with migration to add new columns

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
ui/desktop/src/api/types.gen.ts	Generated TypeScript types for new ModelConfig schema and Session fields
ui/desktop/openapi.json	OpenAPI schema definitions for ModelConfig and updated Session schema
crates/goose/tests/test_support.rs	Updated test helper to include new Session fields
crates/goose/src/session/session_manager.rs	Added database columns, migration logic, and SessionUpdateBuilder methods for provider config
crates/goose/src/scheduler.rs	Updated scheduler to persist provider config after agent setup
crates/goose/src/model.rs	Added ToSchema derive to ModelConfig for OpenAPI generation
crates/goose/src/execution/manager.rs	Added persist_provider_config call when setting up agent with default provider
crates/goose/src/agents/subagent_handler.rs	Added persist_provider_config call when setting provider on sub-agents
crates/goose/src/agents/agent.rs	Implemented persist_provider_config method and integrated it into provider updates
crates/goose-server/src/openapi.rs	Registered ModelConfig schema for OpenAPI documentation
crates/goose-cli/src/session/builder.rs	Added logic to restore provider/model from saved session when resuming

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ui/desktop/src/api/types.gen.ts

crates/goose/src/scheduler.rs

crates/goose/src/agents/agent.rs

DOsinga

would love to get something like this in, but I have a slight feel of unease with the separate save

crates/goose/src/agents/agent.rs

* main: (31 commits) Standardize CLI argument flags and update documentation (#5516) Release 1.13.0 fix: move goosehints/AGENTS.md handling to goose, and out of developer extension (#5575) fix: add standard context menu items to prevent empty right-click menu (#5616) Bump openapi in prepare-release (#5611) docs: add access control section to Developer tutorial (#5615) Token state not showing on load, or after message is finished. (#5606) Change the other location too (#5608) feat(ui): bring back quick launcher (#5144) Support platform tools through CLI (#5570) Avoid web double write (#5601) fix: gemini flash -> pro for mcp smoke tests (#5574) Manual compaction test and fix (#5568) fix: tidy up claude cli handling (#5594) Remove jetbrains (#5602) feat(githubcopilot): add support for newer Copilot AI Models (#5603) fix: customised recipe to yaml string to avoid minininjia parsing error (#5494) Add pending extension indicator to extension panel (#5493) Add environment subsition for auth blocks (#5439) acp: ToolCallLocations and working cancellation (#5588) ...

Copilot

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ui/desktop/src/api/types.gen.ts

Copilot

Pull Request Overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

* main: (65 commits) Fix: Recipes respect the quiet flag (#5743) docs: update cli commands (#5744) Run smoke tests on a free runner (#5745) faster, cheaper (pick two): improve CI workflow and switch to free github runner (#5702) Compaction resiliency improvements (#5618) docs: ask goose button (#5730) Update prompt injection detection metrics (due to errors exporting to datadog) (#5692) Spence/icon2 tokyo drift (#5728) docs: logs rotation and misc updates (#5727) docs: automatic ollama model detection (#5725) Fix context progress bar not resetting after /clear command (#5652) docs: removing double announcements (#5714) docs: mcp sampling support (#5708) hackathon banner (#5710) Fix documentation-only change detection for push events (#5712) Added transaction commits to multi sql functions in session_manager (#5693) fix: improve and simplify tool call chain rendering (#5704) Fix: Always show autocompact threshold ui (#5701) chore: Update governance to include Discord (#5690) Ollama improvements (#5609) ...

Copilot

Pull Request Overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated no new comments.

* main: (33 commits) fix: support Gemini 3's thought signatures (#5806) chore: Add Adrian Cole to Maintainers (#5815) [MCP-UI] Proxy and Better Message Handling (#5487) Release 1.15.0 Document New Window menu in macOS dock (#5811) Catch cron errors (#5707) feat/fix Re-enabled WAL with commit transaction management (Linux Verification Requested) (#5793) chore: remove autopilot experimental feature (#5781) Read paths from an interactive & login shell (#5774) docs: acp clients (#5800) Provider error proxy for simulating various types of errors (#5091) chore: Add links to maintainer profiles (#5788) Quick fix for community all stars script (#5798) Document Mistral AI provider (#5799) docs: Add Community Stars recipe script and txt file (#5776) chore: incorporate LF feedback (#5787) docs: quick launcher (#5779) Bump auto scroll threshold (#5738) fix: add one-time cleanup for linux hermit locking issues (#5742) Don't show update tray icon if GOOSE_VERSION is set (#5750) ...

crates/goose-cli/src/commands/acp.rs

crates/goose-cli/src/commands/web.rs

crates/goose/examples/agent.rs

* main: fix: Parse maas models for gcp vertex provider (#5816)

Copilot

Pull Request Overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated no new comments.

Copilot

Pull Request Overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated no new comments.

* main: (48 commits) [fix] generic check for gemini compat (#5842) Add scheduler to diagnostics (#5849) Cors and token (#5850) fix sessions coming back with empty messages (#5841) markdown export from URL (#5830) Next camp refactor live (#5706) Add out of context compaction test via error proxy (#5805) fix: Add backward compatibility for conversationCompacted message type (#5819) Add /agent/stop endpoint, make max active agents configurable (#5826) Handle 404s (#5791) Persist provider name and model config in the session (#5419) Comment out the flaky mcp callers (#5827) Slash commands (#5718) fix: remove setx calls to not permanently edit the windows shell PATH (#5821) fix: Parse maas models for gcp vertex provider (#5816) fix: support Gemini 3's thought signatures (#5806) chore: Add Adrian Cole to Maintainers (#5815) [MCP-UI] Proxy and Better Message Handling (#5487) Release 1.15.0 Document New Window menu in macOS dock (#5811) ...

Signed-off-by: Blair Allan <[email protected]>

wpfleger96 added 4 commits October 28, 2025 16:10

Persist provider name and model config in the session

9166dec

fix test

008fc7f

forgot to update openapi schema

363b124

wpfleger96 requested a review from DOsinga October 30, 2025 16:56

Copilot AI review requested due to automatic review settings November 4, 2025 23:17

Copilot AI reviewed Nov 4, 2025

View reviewed changes

ui/desktop/src/api/types.gen.ts Show resolved Hide resolved

crates/goose/src/scheduler.rs Outdated Show resolved Hide resolved

crates/goose/src/agents/agent.rs Outdated Show resolved Hide resolved

Address copilot feedback

a15bd93

DOsinga reviewed Nov 6, 2025

View reviewed changes

crates/goose/src/agents/agent.rs Outdated Show resolved Hide resolved

wpfleger96 mentioned this pull request Nov 6, 2025

Add database management API and automatic migration backups #5490

Closed

9 tasks

Copilot AI review requested due to automatic review settings November 6, 2025 23:11

Copilot AI reviewed Nov 6, 2025

View reviewed changes

wpfleger96 added 2 commits November 14, 2025 13:54

updating provider should always persist too

9487176

/agent/resume endpoint should use persisted provider/model if available

13e8b05

Copilot AI review requested due to automatic review settings November 14, 2025 20:55

Copilot started reviewing on behalf of wpfleger96 November 14, 2025 20:55 View session

Copilot finished reviewing on behalf of wpfleger96 November 14, 2025 20:57

Copilot AI reviewed Nov 14, 2025

View reviewed changes

wpfleger96 added 2 commits November 14, 2025 16:52

simplification

75811cd

Copilot AI review requested due to automatic review settings November 14, 2025 22:22

Copilot started reviewing on behalf of wpfleger96 November 14, 2025 22:23 View session

Copilot finished reviewing on behalf of wpfleger96 November 14, 2025 22:25

Copilot AI reviewed Nov 14, 2025

View reviewed changes

wpfleger96 added 2 commits November 20, 2025 11:16

appease clippy

6d30887

DOsinga approved these changes Nov 20, 2025

View reviewed changes

crates/goose-cli/src/commands/acp.rs Show resolved Hide resolved

crates/goose-cli/src/commands/web.rs Show resolved Hide resolved

crates/goose/examples/agent.rs Outdated Show resolved Hide resolved

tlongwell-block mentioned this pull request Nov 20, 2025

Add /agent/stop endpoint, make max active agents configurable #5826

Merged

Merge branch 'main' into wpfleger/persist-provider-config

127272e

* main: fix: Parse maas models for gcp vertex provider (#5816)

Copilot AI review requested due to automatic review settings November 20, 2025 18:20

Copilot started reviewing on behalf of wpfleger96 November 20, 2025 18:21 View session

Copilot finished reviewing on behalf of wpfleger96 November 20, 2025 18:23

Copilot AI reviewed Nov 20, 2025

View reviewed changes

wpfleger96 added 2 commits November 20, 2025 15:05

address PR feedback

8c88327

we should standardize error handling in the example

ff6ce42

Copilot AI review requested due to automatic review settings November 20, 2025 20:51

Copilot started reviewing on behalf of wpfleger96 November 20, 2025 20:52 View session

Copilot finished reviewing on behalf of wpfleger96 November 20, 2025 20:54

Copilot AI reviewed Nov 20, 2025

View reviewed changes

wpfleger96 merged commit 682e315 into main Nov 20, 2025
22 checks passed

wpfleger96 deleted the wpfleger/persist-provider-config branch November 20, 2025 20:55

zanesq mentioned this pull request Nov 21, 2025

fix sessions coming back with empty messages #5841

Merged

github-actions bot mentioned this pull request Nov 25, 2025

chore(release): release version 1.16.0 (minor) #5867

Closed

BlairAllan pushed a commit to BlairAllan/goose that referenced this pull request Nov 29, 2025

Persist provider name and model config in the session (block#5419)

10b6063

Signed-off-by: Blair Allan <[email protected]>

github-actions bot mentioned this pull request Dec 4, 2025

chore(release): release version 1.16.0 (minor) #5985

Merged

Persist provider name and model config in the session #5419

Persist provider name and model config in the session #5419

Uh oh!

Conversation

wpfleger96 commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Related Issues

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DOsinga left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wpfleger96 commented Oct 28, 2025 •

edited

Loading