use app.isPackaged instead of checking for node env development

[zanesq]

Summary

use app.isPackaged instead of checking for node env development

[DOsinga]

I'm going to take this over if you don't mind while you are absent @zanesq

[Copilot]

Pull Request Overview

This PR refactors environment detection across the Electron desktop application by replacing process.env.NODE_ENV === 'development' checks with !app.isPackaged, providing a more reliable way to determine development vs production mode. Additionally, it removes unused development-only testing utilities from the costDatabase module.

Key Changes

• Standardized environment detection using app.isPackaged instead of NODE_ENV
• Simplified logger configuration by removing special development-only log paths
• Removed unused development testing utilities and window object exposure from costDatabase

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
ui/desktop/src/utils/pathUtils.ts	Simplified development check in path resolution logic
ui/desktop/src/utils/logger.ts	Unified log path handling and replaced NODE_ENV checks with app.isPackaged
ui/desktop/src/utils/costDatabase.ts	Removed obsolete comment and unused development testing utilities
ui/desktop/src/utils/autoUpdater.ts	Replaced NODE_ENV check with app.isPackaged for icon path resolution
ui/desktop/src/main.ts	Updated tray icon logic to use app.isPackaged

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The log file path uses forward slashes which will work on all platforms thanks to Node.js path normalization, but for consistency with the rest of the codebase and clarity, consider using 'path.join(app.getPath('userData'), 'logs', 'main.log')' which is already correct. However, verify that the 'logs' directory will be created automatically. If not, this could cause a runtime error when the app tries to write to a non-existent directory.

Suggested change

	import { app } from 'electron';
	import { app } from 'electron';
	import fs from 'node:fs';
	// Ensure the 'logs' directory exists
	const logsDir = path.join(app.getPath('userData'), 'logs');
	if (!fs.existsSync(logsDir)) {
	fs.mkdirSync(logsDir, { recursive: true });
	}

[Copilot]

Removed comment 'Import the proper type from ConfigContext' which was inaccurate since this file doesn't import anything from ConfigContext.