fix: Add backward compatibility for conversationCompacted message type #5819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaibhavgeek
force-pushed
the
fix/backward-compatibility-conversation-compacted
branch
3 times, most recently
from
08d5e34 to
4036477
Compare
katzdave
reviewed
Nov 20, 2025
Collaborator
katzdave
left a comment
katzdave
left a comment
There was a problem hiding this comment.
Nice thanks for the quick fix!
|
|
||
| let mut raw: Vec<serde_json::Value> = Vec::deserialize(deserializer)?; | ||
|
|
||
| // Convert old "conversationCompacted" to "systemNotification" for backward compatibility |
Collaborator
There was a problem hiding this comment.
Can we add to this comment pre 14.0
| for item in &mut raw { | ||
| if let Some(obj) = item.as_object_mut() { | ||
| if obj.get("type").and_then(|v| v.as_str()) == Some("conversationCompacted") { | ||
| obj.insert("type".to_string(), serde_json::json!("systemNotification")); |
Collaborator
There was a problem hiding this comment.
we can just get rid of inserting the new message. Let's just not write the old conversationCompacted.
Contributor
Author
There was a problem hiding this comment.
modified it to cleaner code,
raw.retain(|item|
item.get("type").and_then(|v| v.as_str()) != Some("conversationCompacted")
);
| } | ||
|
|
||
| #[test] | ||
| fn test_backward_compatibility_conversation_compacted() { |
Collaborator
There was a problem hiding this comment.
No need for test if we simplify the logic.
Contributor
Author
There was a problem hiding this comment.
removed the test.
vaibhavgeek
force-pushed
the
fix/backward-compatibility-conversation-compacted
branch
5 times, most recently
from
8e7a516 to
3bfffde
Compare
katzdave
approved these changes
Nov 20, 2025
| let mut content: Vec<MessageContent> = serde_json::from_value(serde_json::Value::Array(raw)) | ||
| .map_err(|e| Error::custom(format!("Failed to deserialize MessageContent: {}", e)))?; | ||
|
|
||
| // Sanitize text content |
Collaborator
There was a problem hiding this comment.
we can drop little comments like this (the obe above is ok tho)
Contributor
Author
There was a problem hiding this comment.
I will be more careful with AI slop comments from now on.
Collaborator
|
nice one @vaibhavgeek |
Remove conversationCompacted messages instead of converting them to maintain compatibility with pre 14.0 versions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Vaibhav Maheshwari <[email protected]>
Signed-off-by: Vaibhav Maheshwari <[email protected]>
vaibhavgeek
force-pushed
the
fix/backward-compatibility-conversation-compacted
branch
from
f95e8c5 to
550156a
Compare
michaelneale
added a commit
that referenced
this pull request
Nov 24, 2025
* main: (48 commits) [fix] generic check for gemini compat (#5842) Add scheduler to diagnostics (#5849) Cors and token (#5850) fix sessions coming back with empty messages (#5841) markdown export from URL (#5830) Next camp refactor live (#5706) Add out of context compaction test via error proxy (#5805) fix: Add backward compatibility for conversationCompacted message type (#5819) Add /agent/stop endpoint, make max active agents configurable (#5826) Handle 404s (#5791) Persist provider name and model config in the session (#5419) Comment out the flaky mcp callers (#5827) Slash commands (#5718) fix: remove setx calls to not permanently edit the windows shell PATH (#5821) fix: Parse maas models for gcp vertex provider (#5816) fix: support Gemini 3's thought signatures (#5806) chore: Add Adrian Cole to Maintainers (#5815) [MCP-UI] Proxy and Better Message Handling (#5487) Release 1.15.0 Document New Window menu in macOS dock (#5811) ...
kskarthik
pushed a commit
to kskarthik/goose
that referenced
this pull request
Nov 25, 2025
block#5819) Signed-off-by: Vaibhav Maheshwari <[email protected]> Co-authored-by: Claude <[email protected]>
kskarthik
pushed a commit
to kskarthik/goose
that referenced
this pull request
Nov 26, 2025
block#5819) Signed-off-by: Vaibhav Maheshwari <[email protected]> Co-authored-by: Claude <[email protected]> Signed-off-by: Sai Karthik <[email protected]>
BlairAllan
pushed a commit
to BlairAllan/goose
that referenced
this pull request
Nov 29, 2025
block#5819) Signed-off-by: Vaibhav Maheshwari <[email protected]> Co-authored-by: Claude <[email protected]> Signed-off-by: Blair Allan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically converts legacy "conversationCompacted" messages to the new "systemNotification" format with "thinkingMessage" type during deserialization. This ensures older conversation history can be loaded without breaking changes.
Added test coverage for the backward compatibility conversion.
🤖 Generated with Claude Code
Summary
Type of Change
AI Assistance
Testing
Related Issues
Relates to #5804
Discussion: #5804 (comment)
Screenshots/Demos (for UX changes)
Before:
After:
Submitting a Recipe?
Email: