Skip to content

improvement: add useful error message when attempting to use unauthenticated cursor-agent #5300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DOsinga merged 2 commits into from
Nov 4, 2025
Merged

improvement: add useful error message when attempting to use unauthenticated cursor-agent #5300

DOsinga merged 2 commits into from
Nov 4, 2025

Conversation

@alexeyre
Copy link
Contributor

@alexeyre alexeyre commented Oct 21, 2025

Summary

Adds logic to check the authentication status of cursor-agent via cursor-agent status in get_authentication_status and adds a check in execute_command. Previous behaviour was to output an error of Some(1) when trying to use cursor-agent while unauthenticated.

Type of Change

  • Feature
  • Bug fix
  • Refactor / Code quality
  • Performance improvement
  • Documentation
  • Tests
  • Security fix
  • Build / Release
  • Other (specify below)

Testing

Manual testing with an unauthenticated cursor-agent, ran tests and linter.

Related Issues

Relates to #5298

DOsinga
DOsinga approved these changes Oct 21, 2025
View reviewed changes
Copy link
Collaborator

@DOsinga DOsinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I think we can make it more compact though. also drop any redundant comments

@alexeyre alexeyre force-pushed the cursor-agent-auth-error-message branch from 6ca56d9 to bf027f9 Compare October 21, 2025 19:37
@alexeyre
Copy link
Contributor Author

alexeyre commented Oct 21, 2025

@DOsinga implemented your refactored version, the logic is correct but error message appears to be coming via the chat rather than the error dialogue I first encountered so I'm unsure whether this is appropriate to commit as-is. Not super familiar with the codebase yet so very possible I'm not throwing the error in the correct way, feedback very much appreciated!

@alexeyre alexeyre force-pushed the cursor-agent-auth-error-message branch from 59621f9 to be51025 Compare November 3, 2025 12:33
Copilot AI review requested due to automatic review settings November 3, 2025 12:33
Copilot AI reviewed Nov 3, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds authentication status checking to the cursor-agent provider by detecting when users are not logged in and returning a more helpful error message.

  • Added a new get_authentication_status method to check if the user is logged in to cursor-agent
  • Enhanced error handling in execute_command to detect authentication failures and provide clearer guidance

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alexeyre
Copy link
Contributor Author

alexeyre commented Nov 3, 2025

@DOsinga if this is still wanted I'm unable to run the required approving workflows to allow merging

@DOsinga DOsinga merged commit 1437d1f into block:main Nov 4, 2025
20 checks passed
@DOsinga
Copy link
Collaborator

DOsinga commented Nov 4, 2025

thank you @alexeyre !

katzdave added a commit that referenced this pull request Nov 4, 2025
@katzdave
Merge branch 'main' of github.com:block/goose into dkatz/compaction-t…
7c3977a 
…est-and-fix

* 'main' of github.com:block/goose:
  improve linux tray icon support (#5425)
  feat: log rotation (#5561)
  use app.isPackaged instead of checking for node env development (#5465)
  disable RPM build-ID generation to prevent package conflicts (#5563)
  Add Diagnostics Info to Q&A and Bug Report Templates (#5565)
  fix: improve server error messages to include HTTP status code (#5532)
  improvement: add useful error message when attempting to use unauthenticated cursor-agent (#5300)
  fix: unblock acp via databricks (#5562)
  feat: add --output-format json flag to goose run command (#5525)
wpfleger96 added a commit that referenced this pull request Nov 4, 2025
@wpfleger96
Merge branch 'main' into wpfleger/persist-provider-config
a07941e 
* main: (85 commits)
  improve linux tray icon support (#5425)
  feat: log rotation (#5561)
  use app.isPackaged instead of checking for node env development (#5465)
  disable RPM build-ID generation to prevent package conflicts (#5563)
  Add Diagnostics Info to Q&A and Bug Report Templates (#5565)
  fix: improve server error messages to include HTTP status code (#5532)
  improvement: add useful error message when attempting to use unauthenticated cursor-agent (#5300)
  fix: unblock acp via databricks (#5562)
  feat: add --output-format json flag to goose run command (#5525)
  Sessions required (#5548)
  feat: add grouped extension loading notification (#5529)
  we should run this on main and also test open models at least via ope… (#5556)
  info: print location of sessions.db via goose info (#5557)
  chore: remove yarn usage from documentation (#5555)
  cli: adjust default theme to address #1905 (#5552)
  Manual compaction counting fix + cli cleanup (#5480)
  chore(deps): bump prismjs and react-syntax-highlighter in /ui/desktop (#5549)
  fix: remove qwen3-coder from provider/mcp smoke tests (#5551)
  fix: do not build unsigned desktop app bundles on every PR in ci. add manual option. (#5550)
  fix: update Husky prepare script to v9 format (#5522)
  ...
wpfleger96 added a commit that referenced this pull request Nov 5, 2025
@wpfleger96
Merge branch 'main' into wpfleger/db-cli
0164300 
* main: (54 commits)
  add clippy warning for string_slice (#5422)
  improve linux tray icon support (#5425)
  feat: log rotation (#5561)
  use app.isPackaged instead of checking for node env development (#5465)
  disable RPM build-ID generation to prevent package conflicts (#5563)
  Add Diagnostics Info to Q&A and Bug Report Templates (#5565)
  fix: improve server error messages to include HTTP status code (#5532)
  improvement: add useful error message when attempting to use unauthenticated cursor-agent (#5300)
  fix: unblock acp via databricks (#5562)
  feat: add --output-format json flag to goose run command (#5525)
  Sessions required (#5548)
  feat: add grouped extension loading notification (#5529)
  we should run this on main and also test open models at least via ope… (#5556)
  info: print location of sessions.db via goose info (#5557)
  chore: remove yarn usage from documentation (#5555)
  cli: adjust default theme to address #1905 (#5552)
  Manual compaction counting fix + cli cleanup (#5480)
  chore(deps): bump prismjs and react-syntax-highlighter in /ui/desktop (#5549)
  fix: remove qwen3-coder from provider/mcp smoke tests (#5551)
  fix: do not build unsigned desktop app bundles on every PR in ci. add manual option. (#5550)
  ...
@github-actions github-actions bot mentioned this pull request Nov 5, 2025
Merged
michaelneale added a commit that referenced this pull request Nov 6, 2025
@michaelneale
Merge branch 'main' into micn/goose-mobile-access
f4a3b59 
* main: (53 commits)
  acp: ToolCallLocations and working cancellation (#5588)
  feat(providers): add Mistral AI provider (#5009)
  Listen for ctrl-c during provider request (#5585)
  Also accept null as description, not just missing (#5589)
  Document missing recipe param types (#5584)
  docs: description required for "Add Extension" in cli (#5573)
  fix: Add schema-aware numeric coercion for MCP tool arguments (#5478)
  Add uv for uvx in Justfile (#5581)
  Keep llm logs in place (#5577)
  bump to 1.12.0 (#5580)
  automate more of the release process (#5409)
  add clippy warning for string_slice (#5422)
  improve linux tray icon support (#5425)
  feat: log rotation (#5561)
  use app.isPackaged instead of checking for node env development (#5465)
  disable RPM build-ID generation to prevent package conflicts (#5563)
  Add Diagnostics Info to Q&A and Bug Report Templates (#5565)
  fix: improve server error messages to include HTTP status code (#5532)
  improvement: add useful error message when attempting to use unauthenticated cursor-agent (#5300)
  fix: unblock acp via databricks (#5562)
  ...
fbalicchia pushed a commit to fbalicchia/goose that referenced this pull request Nov 7, 2025
@alexeyre @fbalicchia
improvement: add useful error message when attempting to use unauthen…
20ef792 
…ticated cursor-agent (block#5300)

Signed-off-by: Alex Holder <[email protected]>
Signed-off-by: fbalicchia <[email protected]>
BlairAllan pushed a commit to BlairAllan/goose that referenced this pull request Nov 29, 2025
@alexeyre @BlairAllan
improvement: add useful error message when attempting to use unauthen…
d0f8226 
…ticated cursor-agent (block#5300)

Signed-off-by: Alex Holder <[email protected]>
Signed-off-by: Blair Allan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@DOsinga DOsinga DOsinga approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexeyre @DOsinga