Support platform tools through CLI

[DOsinga]

Since platform tools are built-in but have their own type you couldn't explicitly enable them through the CLI. This changes that

[Copilot]

Pull Request Overview

This PR updates the add_builtin method to differentiate between platform extensions and builtin extensions. Platform extensions (like todo and extensionmanager) are now properly routed to use ExtensionConfig::Platform instead of ExtensionConfig::Builtin. The test script is also updated to include the new platform extensions in testing.

• Adds logic to check if an extension is a platform extension using PLATFORM_EXTENSIONS
• Routes platform extensions to ExtensionConfig::Platform configuration
• Updates test script to include todo and extensionmanager in the builtin list

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
scripts/test_providers.sh	Adds todo and extensionmanager to the list of builtin extensions tested
crates/goose-cli/src/session/mod.rs	Implements conditional logic to create Platform vs Builtin extension configs based on extension type

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The contains_key check uses the untrimmed name variable, but PLATFORM_EXTENSIONS keys are lowercase without spaces (e.g., "extensionmanager", "todo", "chatrecall"). The trimmed extension_name should be used here, or better yet, apply the same normalize() function used in extension_manager.rs which strips whitespace and converts to lowercase. Without this, platform extensions won't be recognized unless the user provides the exact key format.

[Copilot]

The name parameter is being called with trim() twice: once to create extension_name (line 300) and again here (line 306). Use extension_name consistently throughout both branches instead of re-trimming name.

Suggested change

	description: name.trim().to_string(),
	available_tools: Vec::new(),
	}
	} else {
	ExtensionConfig::Builtin {
	name: extension_name,
	display_name: None,
	timeout: None,
	bundled: None,
	description: name.trim().to_string(),
	description: extension_name.clone(),
	available_tools: Vec::new(),
	}
	} else {
	ExtensionConfig::Builtin {
	name: extension_name.clone(),
	display_name: None,
	timeout: None,
	bundled: None,
	description: extension_name,

[Copilot]

The name parameter is being called with trim() twice: once to create extension_name (line 300) and again here (line 315). Use extension_name consistently throughout both branches instead of re-trimming name.

Suggested change

	name: extension_name,
	bundled: None,
	description: name.trim().to_string(),
	available_tools: Vec::new(),
	}
	} else {
	ExtensionConfig::Builtin {
	name: extension_name,
	display_name: None,
	timeout: None,
	bundled: None,
	description: name.trim().to_string(),
	name: extension_name.clone(),
	bundled: None,
	description: extension_name.clone(),
	available_tools: Vec::new(),
	}
	} else {
	ExtensionConfig::Builtin {
	name: extension_name.clone(),
	display_name: None,
	timeout: None,
	bundled: None,
	description: extension_name.clone(),

[alexhancock]

(rebased this because I want to see if the provider tests are more reliable after recent merges)

[alexhancock]

what is the effect of the switch to have no timeout vs the prior

Some(goose::config::DEFAULT_EXTENSION_TIMEOUT)

?

[alexhancock]

Interested to know, but doesn't seem like a big deal to me as we wouldn't expect the builtins to time out conceptually

[Copilot]

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Inconsistent description field usage. Line 308 uses name.to_string() while line 317 also uses name.to_string(), but extension_name was already trimmed on line 302. Line 308 should use extension_name.to_string() to avoid potential whitespace in the description.

[Copilot]

The description field should use extension_name.to_string() instead of name.to_string() to ensure it uses the trimmed version of the name and maintains consistency with the name field on line 313.