faster, cheaper (pick two): improve CI workflow and switch to free github runner #5702

jamadeo · 2025-11-12T17:41:19Z

This:

splits jobs in CI
uses better caching
uses the free github runner

with the end goal of opening up our workflows to run on fork PRs without approval

Copilot

Pull Request Overview

This PR modernizes the CI infrastructure by migrating from a custom runner to GitHub's free ubuntu-latest runners, implementing better caching strategies, and splitting jobs for improved parallelization. The changes enable the workflow to run on fork PRs without approval while reducing infrastructure costs.

Key Changes:

Replaced custom "goose" runner with ubuntu-latest for Rust jobs
Migrated from manual cache configuration to Swatinem/rust-cache@v2 action across all workflows
Split CI jobs into separate format, build-test, lint, and openapi-schema-check jobs for better parallelization
Improved test isolation by using thread-specific temporary directories in test mode

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
`.github/workflows/ci.yml`	Splits monolithic job into separate format, build-test, lint, and openapi-schema-check jobs; switches to ubuntu-latest runner and rust-cache
`.github/workflows/pr-smoke-test.yml`	Replaces manual cache configuration with rust-cache action
`.github/workflows/bundle-desktop.yml`	Consolidates three separate cargo cache steps into single rust-cache action
`.github/workflows/bundle-desktop-windows.yml`	Simplifies Windows cross-compilation cache to use rust-cache
`.github/workflows/bundle-desktop-linux.yml`	Updates Linux cross-compilation to use rust-cache with custom key
`.github/workflows/bundle-desktop-intel.yml`	Consolidates Intel macOS cache steps into single rust-cache action
`.github/workflows/build-cli.yml`	Updates CLI build caching for both cross-platform and Windows builds
`crates/goose/src/session/session_manager.rs`	Adds thread-specific test directories to prevent test isolation issues; moves Paths import to non-test code only
`scripts/clippy-baseline.sh`	Removes trailing whitespace; adds tee to clippy output for better visibility

.github/workflows/bundle-desktop-windows.yml

Co-authored-by: Copilot <[email protected]>

DOsinga · 2025-11-14T15:48:40Z

.github/workflows/build-cli.yml

-      - name: Cache Cargo registry (Windows)
-        if: matrix.use-docker
-        uses: actions/cache@2f8e54208210a422b2efd51efaa6bd6d7ca8920f
+      # Cache Cargo artifacts for cross-platform builds


might as well drop the comment (or change it into the name below)

DOsinga · 2025-11-14T15:50:37Z

.github/workflows/ci.yml

      - name: Lint
        run: |
          source ./bin/activate-hermit
+          hermit uninstall rustup


why is that needed?

maybe this could do with a comment

The swatinem/rust-cache github action is the go-to for caching rust projects because it does a good job of filtering out all of the incremental artifacts created from compiling your own project code, and keeping the dependencies. But there's one problem with our setup: it distinguishes between first and third party code by looking at the path on disk, and if the artifact source path prefix-matches your project directory, it marks it as (non-cached) project code. When we use hermit, the CARGO_HOME is within the project directory, whereas in a typical setup it would be at ~/.cargo.

Here, since this step needs both rust (for the openapi code gen) plus npm and just, it made sense to just remove the rust bit from hermit while keeping the other parts.

This problem goes away if we decide to stop using hermit for the rust toolchain.

Copilot

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Copilot · 2025-11-14T15:52:02Z

crates/goose/src/session/session_manager.rs

+        let temp_base = std::env::temp_dir().join("goose_test");
+        let session_dir = temp_base
+            .join(format!("thread_{:?}", thread_id))
+            .join(SESSIONS_FOLDER);


Test directories in temp aren't cleaned up automatically. Consider using a test setup/teardown pattern or document that CI should clean /tmp between runs.

Copilot

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Copilot · 2025-11-14T16:41:58Z

crates/goose/src/session/session_manager.rs

+        let session_dir = temp_base
+            .join(format!("thread_{:?}", thread_id))
+            .join(SESSIONS_FOLDER);
+        eprintln!("session dir: {session_dir:?}");


Debug print statement left in production code. Remove or convert to proper tracing/logging if needed for debugging.

Suggested change

eprintln!("session dir: {session_dir:?}");

Copilot

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

.github/workflows/ci.yml

Copilot · 2025-11-14T17:07:06Z

crates/goose/src/session/session_manager.rs

+        let thread_id = std::thread::current().id();
+        let temp_base = std::env::temp_dir().join("goose_test");
+        let session_dir = temp_base
+            .join(format!("thread_{:?}", thread_id))


Using ThreadId with {:?} formatting creates non-deterministic paths across test runs (e.g., ThreadId(123) vs ThreadId(456)), which breaks cache persistence. For tokio async tests, this also won't provide proper isolation since multiple tests may run on the same thread from the tokio runtime thread pool.

Suggested change

let thread_id = std::thread::current().id();

let temp_base = std::env::temp_dir().join("goose_test");

let session_dir = temp_base

.join(format!("thread_{:?}", thread_id))

let process_id = std::process::id();

let temp_base = std::env::temp_dir().join("goose_test");

let session_dir = temp_base

.join(format!("test_session_{}", process_id))

Copilot

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

Copilot

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Copilot · 2025-11-14T17:41:11Z

scripts/clippy-baseline.sh

    local temp_json=$(mktemp)
-    cargo clippy --jobs 2 --message-format=json -- $clippy_flags > "$temp_json"
-    
+    cargo clippy --jobs 2 --message-format=json -- $clippy_flags | tee "$temp_json"


Using tee here will output all clippy JSON diagnostics to stdout, creating noise in CI logs. The original > redirect was silent. Consider reverting to > \"$temp_json\" unless the verbose JSON output is intentionally needed for debugging.

Suggested change

cargo clippy --jobs 2 --message-format=json -- $clippy_flags | tee "$temp_json"

cargo clippy --jobs 2 --message-format=json -- $clippy_flags > "$temp_json"

* main: (65 commits) Fix: Recipes respect the quiet flag (#5743) docs: update cli commands (#5744) Run smoke tests on a free runner (#5745) faster, cheaper (pick two): improve CI workflow and switch to free github runner (#5702) Compaction resiliency improvements (#5618) docs: ask goose button (#5730) Update prompt injection detection metrics (due to errors exporting to datadog) (#5692) Spence/icon2 tokyo drift (#5728) docs: logs rotation and misc updates (#5727) docs: automatic ollama model detection (#5725) Fix context progress bar not resetting after /clear command (#5652) docs: removing double announcements (#5714) docs: mcp sampling support (#5708) hackathon banner (#5710) Fix documentation-only change detection for push events (#5712) Added transaction commits to multi sql functions in session_manager (#5693) fix: improve and simplify tool call chain rendering (#5704) Fix: Always show autocompact threshold ui (#5701) chore: Update governance to include Discord (#5690) Ollama improvements (#5609) ...

* main: scan recipe for security when saving recipe (#5747) feat: trying grok for live test (#5732) Platform Extension MOIM (Minus One Info Message) (#5027) docs: remove hackathon banner (#5756) Fix: Recipes respect the quiet flag (#5743) docs: update cli commands (#5744) Run smoke tests on a free runner (#5745) faster, cheaper (pick two): improve CI workflow and switch to free github runner (#5702) Compaction resiliency improvements (#5618) docs: ask goose button (#5730) Update prompt injection detection metrics (due to errors exporting to datadog) (#5692) Spence/icon2 tokyo drift (#5728) docs: logs rotation and misc updates (#5727) docs: automatic ollama model detection (#5725) Fix context progress bar not resetting after /clear command (#5652) docs: removing double announcements (#5714) docs: mcp sampling support (#5708)

…thub runner (block#5702) Co-authored-by: Douwe Osinga <[email protected]> Co-authored-by: Copilot <[email protected]>

…thub runner (block#5702) Co-authored-by: Douwe Osinga <[email protected]> Co-authored-by: Copilot <[email protected]> Signed-off-by: Blair Allan <[email protected]>

jamadeo force-pushed the jackamadeo/use-gh-free-runner branch 6 times, most recently from 1715ab2 to aa9b866 Compare November 14, 2025 14:01

faster, cheaper (pick two)

1f1bb64

jamadeo force-pushed the jackamadeo/use-gh-free-runner branch from 091b3ad to 1f1bb64 Compare November 14, 2025 14:34

jamadeo changed the title ~~Use the free github runner~~ faster, cheaper (pick two): improve CI workflow and switch to free github runner Nov 14, 2025

jamadeo marked this pull request as ready for review November 14, 2025 15:04

Copilot AI review requested due to automatic review settings November 14, 2025 15:04

Copilot started reviewing on behalf of jamadeo November 14, 2025 15:05 View session

jamadeo requested review from DOsinga and alexhancock November 14, 2025 15:05

Copilot finished reviewing on behalf of jamadeo November 14, 2025 15:07

Copilot AI reviewed Nov 14, 2025

View reviewed changes

.github/workflows/bundle-desktop-windows.yml Outdated Show resolved Hide resolved

Update .github/workflows/bundle-desktop-windows.yml

3dba09b

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings November 14, 2025 15:49

Copilot started reviewing on behalf of DOsinga November 14, 2025 15:50 View session

DOsinga approved these changes Nov 14, 2025

View reviewed changes

Copilot finished reviewing on behalf of DOsinga November 14, 2025 15:51

Copilot AI reviewed Nov 14, 2025

View reviewed changes

revert me: test

e715df3

Copilot AI review requested due to automatic review settings November 14, 2025 16:40

jamadeo force-pushed the jackamadeo/use-gh-free-runner branch from 9b41cce to e715df3 Compare November 14, 2025 16:40

Copilot started reviewing on behalf of jamadeo November 14, 2025 16:40 View session

Copilot finished reviewing on behalf of jamadeo November 14, 2025 16:41

Copilot AI reviewed Nov 14, 2025

View reviewed changes

jamadeo added 2 commits November 14, 2025 11:49

again

dd44eba

you have 1 job

ff596dc

Copilot AI review requested due to automatic review settings November 14, 2025 17:04

Copilot started reviewing on behalf of jamadeo November 14, 2025 17:05 View session

add back

34b7527

Copilot finished reviewing on behalf of jamadeo November 14, 2025 17:06

Copilot AI reviewed Nov 14, 2025

View reviewed changes

jamadeo added 2 commits November 14, 2025 12:08

Remove the test code

742fdf2

Meaningless comments

b348b43

Copilot AI review requested due to automatic review settings November 14, 2025 17:10

Copilot started reviewing on behalf of jamadeo November 14, 2025 17:11 View session

Explain ourselves

12e1899

Copilot finished reviewing on behalf of jamadeo November 14, 2025 17:14

the worst of the worst useless comments

4925a05

Copilot AI reviewed Nov 14, 2025

View reviewed changes

jamadeo added 2 commits November 14, 2025 12:22

better cache for smoke tests

65d9aa2

Put this back the way it was

2a86e7f

Copilot AI review requested due to automatic review settings November 14, 2025 17:38

Copilot started reviewing on behalf of jamadeo November 14, 2025 17:39 View session

Copilot finished reviewing on behalf of jamadeo November 14, 2025 17:40

Copilot AI reviewed Nov 14, 2025

View reviewed changes

jamadeo merged commit d4f66f4 into main Nov 14, 2025
23 checks passed

jamadeo mentioned this pull request Nov 14, 2025

Switch to Swatinem/rust-cache #5700

Closed

arul-cc pushed a commit to arul-cc/goose that referenced this pull request Nov 17, 2025

faster, cheaper (pick two): improve CI workflow and switch to free gi…

838444a

…thub runner (block#5702) Co-authored-by: Douwe Osinga <[email protected]> Co-authored-by: Copilot <[email protected]>

github-actions bot mentioned this pull request Nov 18, 2025

chore(release): release version 1.15.0 (minor) #5780

Merged

	cargo clippy --jobs 2 --message-format=json -- $clippy_flags \| tee "$temp_json"
	cargo clippy --jobs 2 --message-format=json -- $clippy_flags > "$temp_json"

faster, cheaper (pick two): improve CI workflow and switch to free github runner #5702

faster, cheaper (pick two): improve CI workflow and switch to free github runner #5702

Uh oh!

Conversation

jamadeo commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

DOsinga Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

DOsinga Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

jamadeo Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jamadeo commented Nov 12, 2025 •

edited

Loading