Compaction resiliency improvements #5618

katzdave · 2025-11-06T20:45:07Z

Additional tool calling tests

Progressively remove tool call outputs from the middle of the conversation to minimize context length.

Fix an issue where the manual compact marker was being preserved.

…atz/tool-loop-cleanup * origin/dkatz/middle-truncation: fmt first pass # Conflicts: # crates/goose/src/context_mgmt/mod.rs

…eanup * 'main' of github.com:block/goose: Standardize CLI argument flags and update documentation (#5516) Release 1.13.0 fix: move goosehints/AGENTS.md handling to goose, and out of developer extension (#5575) fix: add standard context menu items to prevent empty right-click menu (#5616) Bump openapi in prepare-release (#5611) docs: add access control section to Developer tutorial (#5615)

…eanup * 'main' of github.com:block/goose: Use session IDs as task IDs for subagents instead of UUIDs (#5398) Fix the naming (#5628) fix: default tetrate model is broken, replace with haiku-4.5 (#5535) (#5587) Fetch less and use the right SHA (#5621) feat(ui): add custom macOS dock menu with New Window option (#5099) feat: remove hints from recipe prompts (#5622) docs: October 2025 Community All-Stars spotlight, Hacktoberfest edition (#5625) differentiate debug/release in cache key (#5613) Unify subrecipe and subagent execution through shared recipe pipeline (#5082)

Copilot

Pull Request Overview

This PR refactors the context management system to improve compaction handling and make it more testable by:

Changing function signatures to accept &dyn Provider instead of &Agent for better separation of concerns
Implementing progressive tool response removal when context limits are exceeded during summarization
Introducing different continuation messages based on compaction type (manual, auto with recent user message, or during tool loop)

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
crates/goose/src/conversation/mod.rs	Made `merge_consecutive_messages` public to support merging summary and continuation messages
crates/goose/src/context_mgmt/mod.rs	Refactored compaction to use provider directly, added progressive tool response filtering, updated message preservation logic, and added comprehensive tests
crates/goose/src/agents/agent.rs	Updated calls to context management functions to pass `provider` reference instead of agent

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/goose/src/agents/agent.rs

crates/goose/src/context_mgmt/mod.rs

jamadeo · 2025-11-11T20:22:38Z

crates/goose/src/agents/agent.rs

        let needs_auto_compact = !is_manual_compact
-            && crate::context_mgmt::check_if_compaction_needed(self, &conversation, None, &session)
-                .await?;
+            && crate::context_mgmt::check_if_compaction_needed(


any particular reason to not have these imported with a use crate::context_mgmt::{...}?

crates/goose/src/agents/agent.rs

…eanup * 'main' of github.com:block/goose: (46 commits) Fix context progress bar not resetting after /clear command (#5652) docs: removing double announcements (#5714) docs: mcp sampling support (#5708) hackathon banner (#5710) Fix documentation-only change detection for push events (#5712) Added transaction commits to multi sql functions in session_manager (#5693) fix: improve and simplify tool call chain rendering (#5704) Fix: Always show autocompact threshold ui (#5701) chore: Update governance to include Discord (#5690) Ollama improvements (#5609) feat: add Supabase MCP server to registry (#5629) Unlist VS Code extension tutorials from MCP and experimental sections (#5677) fix: make image processing work in github copilot provider (#5687) fix: do not take into account gitignore in developer mcp (#5688) docs: session storage migration (#5682) New maintainers (#5685) chore: Update governance (#5660) chore(release): release version 1.14.0 (minor) (#5676) fix : action icons overlap session title in chat history (#5684) Document recent goose PRs (#5683) ...

Co-authored-by: Copilot <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Copilot · 2025-11-13T20:19:02Z

crates/goose/src/context_mgmt/mod.rs

+            && preserved_user_message.is_some()
+        {
+            // This is the most recent message and we're preserving it by adding a fresh copy
+            MessageMetadata::invisible()


When the most recent message is being preserved, it's set to completely invisible. This means the original user message disappears from both user and agent view. Should use msg.metadata.with_agent_invisible() to keep it user-visible like other compacted messages.

Suggested change

MessageMetadata::invisible()

msg.metadata.with_agent_invisible()

Copilot · 2025-11-13T20:19:03Z

crates/goose/src/agents/agent.rs

                );

-                match crate::context_mgmt::compact_messages(self, &conversation_to_compact, false).await {
+                match crate::context_mgmt::compact_messages(self.provider().await?.as_ref(), &conversation_to_compact, is_manual_compact).await {


The third parameter should be false not is_manual_compact. This is for auto-compaction (needs_auto_compact path) and should preserve the user message. Using is_manual_compact here will incorrectly preserve messages during manual compacts when this branch shouldn't even execute.

Suggested change

match crate::context_mgmt::compact_messages(self.provider().await?.as_ref(), &conversation_to_compact, is_manual_compact).await {

match crate::context_mgmt::compact_messages(self.provider().await?.as_ref(), &conversation_to_compact, false).await {

Co-authored-by: Copilot <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Copilot · 2025-11-13T23:28:41Z

crates/goose/src/context_mgmt/mod.rs

+    for i in 0..num_to_remove {
+        if i % 2 == 0 {
+            let offset = i / 2;
+            if middle > offset {
+                indices_to_remove.push(tool_indices[middle - offset - 1]);
+            }
+        } else {
+            let offset = i / 2;
+            if middle + offset < tool_indices.len() {
+                indices_to_remove.push(tool_indices[middle + offset]);
+            }
+        }
+    }


The middle-out removal logic fails when there's only one tool response. With a single tool response, middle = 0, and the condition middle > offset at line 253 is false for the first (and only) iteration. This means nothing gets added to indices_to_remove, so the tool response won't be removed even when remove_percent is 100. Consider adding: if i == 0 && tool_indices.len() == 1 { indices_to_remove.push(tool_indices[0]); continue; }

Copilot · 2025-11-13T23:28:41Z

crates/goose/src/context_mgmt/mod.rs

+const CONVERSATION_CONTINUATION_TEXT: &str =
+    "The previous message contains a summary that was prepared because a context limit was reached.
+Do not mention that you read a summary or that conversation summarization occurred.
+Just continue the conversation naturally based on the summarized context";


Inconsistent punctuation in continuation text constants. TOOL_LOOP_CONTINUATION_TEXT ends with a period (line 23), but CONVERSATION_CONTINUATION_TEXT (line 18) and MANUAL_COMPACT_CONTINUATION_TEXT (line 28) do not. Consider adding periods to lines 18 and 28 for consistency.

* origin/main: (51 commits) Compaction resiliency improvements (#5618) docs: ask goose button (#5730) Update prompt injection detection metrics (due to errors exporting to datadog) (#5692) Spence/icon2 tokyo drift (#5728) docs: logs rotation and misc updates (#5727) docs: automatic ollama model detection (#5725) Fix context progress bar not resetting after /clear command (#5652) docs: removing double announcements (#5714) docs: mcp sampling support (#5708) hackathon banner (#5710) Fix documentation-only change detection for push events (#5712) Added transaction commits to multi sql functions in session_manager (#5693) fix: improve and simplify tool call chain rendering (#5704) Fix: Always show autocompact threshold ui (#5701) chore: Update governance to include Discord (#5690) Ollama improvements (#5609) feat: add Supabase MCP server to registry (#5629) Unlist VS Code extension tutorials from MCP and experimental sections (#5677) fix: make image processing work in github copilot provider (#5687) fix: do not take into account gitignore in developer mcp (#5688) ...

* main: (65 commits) Fix: Recipes respect the quiet flag (#5743) docs: update cli commands (#5744) Run smoke tests on a free runner (#5745) faster, cheaper (pick two): improve CI workflow and switch to free github runner (#5702) Compaction resiliency improvements (#5618) docs: ask goose button (#5730) Update prompt injection detection metrics (due to errors exporting to datadog) (#5692) Spence/icon2 tokyo drift (#5728) docs: logs rotation and misc updates (#5727) docs: automatic ollama model detection (#5725) Fix context progress bar not resetting after /clear command (#5652) docs: removing double announcements (#5714) docs: mcp sampling support (#5708) hackathon banner (#5710) Fix documentation-only change detection for push events (#5712) Added transaction commits to multi sql functions in session_manager (#5693) fix: improve and simplify tool call chain rendering (#5704) Fix: Always show autocompact threshold ui (#5701) chore: Update governance to include Discord (#5690) Ollama improvements (#5609) ...

* main: scan recipe for security when saving recipe (#5747) feat: trying grok for live test (#5732) Platform Extension MOIM (Minus One Info Message) (#5027) docs: remove hackathon banner (#5756) Fix: Recipes respect the quiet flag (#5743) docs: update cli commands (#5744) Run smoke tests on a free runner (#5745) faster, cheaper (pick two): improve CI workflow and switch to free github runner (#5702) Compaction resiliency improvements (#5618) docs: ask goose button (#5730) Update prompt injection detection metrics (due to errors exporting to datadog) (#5692) Spence/icon2 tokyo drift (#5728) docs: logs rotation and misc updates (#5727) docs: automatic ollama model detection (#5725) Fix context progress bar not resetting after /clear command (#5652) docs: removing double announcements (#5714) docs: mcp sampling support (#5708)

Co-authored-by: Copilot <[email protected]>

Co-authored-by: Copilot <[email protected]> Signed-off-by: Blair Allan <[email protected]>

katzdave added 8 commits October 28, 2025 15:33

first pass

78dbfe8

fmt

7e7d317

change args

3b050bd

rm

250a3bd

merge conflict

9b07c51

Merge remote-tracking branch 'origin/dkatz/middle-truncation' into dk…

99ee9f8

…atz/tool-loop-cleanup * origin/dkatz/middle-truncation: fmt first pass # Conflicts: # crates/goose/src/context_mgmt/mod.rs

provider test

4a55c3e

simply mock provider

9798a49

katzdave mentioned this pull request Nov 6, 2025

fix compaction in tool loops #5392

Closed

katzdave added 11 commits November 6, 2025 15:47

fmt

0cf3c94

more cleanup + fix manual compact bug

ec7f2dd

fmt

64d1f4b

lint

468ce8d

small fix

2109cce

fmt

a168f2e

Fix

12118f7

more testing

bdec3cb

fmt

a30e48e

katzdave marked this pull request as ready for review November 10, 2025 16:57

katzdave requested review from Copilot and jamadeo November 10, 2025 16:57

Copilot AI reviewed Nov 10, 2025

View reviewed changes

crates/goose/src/agents/agent.rs Outdated Show resolved Hide resolved

crates/goose/src/context_mgmt/mod.rs Outdated Show resolved Hide resolved

crates/goose/src/context_mgmt/mod.rs Outdated Show resolved Hide resolved

crates/goose/src/context_mgmt/mod.rs Outdated Show resolved Hide resolved

jamadeo approved these changes Nov 12, 2025

View reviewed changes

katzdave and others added 2 commits November 13, 2025 15:15

Update crates/goose/src/agents/agent.rs

11cd639

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings November 13, 2025 20:17

fix import

b9226fb

Copilot started reviewing on behalf of katzdave November 13, 2025 20:18 View session

Copilot finished reviewing on behalf of katzdave November 13, 2025 20:18

Copilot AI reviewed Nov 13, 2025

View reviewed changes

katzdave and others added 3 commits November 13, 2025 15:19

merge confl

c4b3708

fmt

7138d35

Add . to messages

821076b

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings November 13, 2025 23:24

Copilot started reviewing on behalf of katzdave November 13, 2025 23:25 View session

Copilot finished reviewing on behalf of katzdave November 13, 2025 23:28

Copilot AI reviewed Nov 13, 2025

View reviewed changes

katzdave merged commit bbac7d6 into main Nov 14, 2025
21 checks passed

Surendhar-N-D pushed a commit to Surendhar-N-D/goose that referenced this pull request Nov 17, 2025

Compaction resiliency improvements (block#5618)

fe2b51f

Co-authored-by: Copilot <[email protected]>

arul-cc pushed a commit to arul-cc/goose that referenced this pull request Nov 17, 2025

Compaction resiliency improvements (block#5618)

8e92fc4

Co-authored-by: Copilot <[email protected]>

github-actions bot mentioned this pull request Nov 18, 2025

chore(release): release version 1.15.0 (minor) #5780

Merged

BlairAllan pushed a commit to BlairAllan/goose that referenced this pull request Nov 29, 2025

Compaction resiliency improvements (block#5618)

ebdf8f2

Co-authored-by: Copilot <[email protected]> Signed-off-by: Blair Allan <[email protected]>

	MessageMetadata::invisible()
	msg.metadata.with_agent_invisible()

	match crate::context_mgmt::compact_messages(self.provider().await?.as_ref(), &conversation_to_compact, is_manual_compact).await {
	match crate::context_mgmt::compact_messages(self.provider().await?.as_ref(), &conversation_to_compact, false).await {

Compaction resiliency improvements #5618

Compaction resiliency improvements #5618

Uh oh!

Conversation

katzdave commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jamadeo Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

katzdave Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

katzdave commented Nov 6, 2025 •

edited

Loading