Skip to content

Conversation

@alexhancock
Copy link
Collaborator

Remove yarn usage from documentation. We don't use yarn elsewhere in the project, and we had both yarn.lock and package-lock.json in this dir. We can just use npm equivalents for these

cc @block/goose-devrel

@alexhancock alexhancock requested a review from a team as a code owner November 3, 2025 21:17
Copilot AI review requested due to automatic review settings November 3, 2025 21:17
@alexhancock alexhancock mentioned this pull request Nov 3, 2025
9 tasks
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the documentation tooling from Yarn to npm as the package manager. The changes ensure consistency with npm throughout the documentation setup and build process.

  • Updated all command examples in README from Yarn to npm
  • Removed Yarn-specific debug log entries from .gitignore

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.

File Description
documentation/README.md Updated installation, development, build, and deployment commands to use npm instead of yarn
documentation/.gitignore Removed yarn-debug.log* and yarn-error.log* entries as they are no longer needed

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


```
$ yarn
$ npm i
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Use 'npm install' instead of 'npm i' for consistency with the other npm commands that use the full form ('npm run start', 'npm run build', etc.). While 'npm i' is a valid shorthand, using the full command improves clarity and consistency in documentation.

Suggested change
$ npm i
$ npm install

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@blackgirlbytes blackgirlbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay that's fine

@alexhancock
Copy link
Collaborator Author

will it be annoying for your workflow at all @blackgirlbytes & co?

was just doing this to simplify after reviewing #5453

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://block.github.io/goose/pr-preview/pr-5555/

Built to branch gh-pages at 2025-11-03 21:24 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@alexhancock alexhancock merged commit 69e083e into main Nov 3, 2025
15 checks passed
katzdave added a commit that referenced this pull request Nov 4, 2025
* 'main' of github.com:block/goose:
  Sessions required (#5548)
  feat: add grouped extension loading notification (#5529)
  we should run this on main and also test open models at least via ope… (#5556)
  info: print location of sessions.db via goose info (#5557)
  chore: remove yarn usage from documentation (#5555)
  cli: adjust default theme to address #1905 (#5552)
wpfleger96 added a commit that referenced this pull request Nov 4, 2025
* main: (85 commits)
  improve linux tray icon support (#5425)
  feat: log rotation (#5561)
  use app.isPackaged instead of checking for node env development (#5465)
  disable RPM build-ID generation to prevent package conflicts (#5563)
  Add Diagnostics Info to Q&A and Bug Report Templates (#5565)
  fix: improve server error messages to include HTTP status code (#5532)
  improvement: add useful error message when attempting to use unauthenticated cursor-agent (#5300)
  fix: unblock acp via databricks (#5562)
  feat: add --output-format json flag to goose run command (#5525)
  Sessions required (#5548)
  feat: add grouped extension loading notification (#5529)
  we should run this on main and also test open models at least via ope… (#5556)
  info: print location of sessions.db via goose info (#5557)
  chore: remove yarn usage from documentation (#5555)
  cli: adjust default theme to address #1905 (#5552)
  Manual compaction counting fix + cli cleanup (#5480)
  chore(deps): bump prismjs and react-syntax-highlighter in /ui/desktop (#5549)
  fix: remove qwen3-coder from provider/mcp smoke tests (#5551)
  fix: do not build unsigned desktop app bundles on every PR in ci. add manual option. (#5550)
  fix: update Husky prepare script to v9 format (#5522)
  ...
wpfleger96 added a commit that referenced this pull request Nov 5, 2025
* main: (54 commits)
  add clippy warning for string_slice (#5422)
  improve linux tray icon support (#5425)
  feat: log rotation (#5561)
  use app.isPackaged instead of checking for node env development (#5465)
  disable RPM build-ID generation to prevent package conflicts (#5563)
  Add Diagnostics Info to Q&A and Bug Report Templates (#5565)
  fix: improve server error messages to include HTTP status code (#5532)
  improvement: add useful error message when attempting to use unauthenticated cursor-agent (#5300)
  fix: unblock acp via databricks (#5562)
  feat: add --output-format json flag to goose run command (#5525)
  Sessions required (#5548)
  feat: add grouped extension loading notification (#5529)
  we should run this on main and also test open models at least via ope… (#5556)
  info: print location of sessions.db via goose info (#5557)
  chore: remove yarn usage from documentation (#5555)
  cli: adjust default theme to address #1905 (#5552)
  Manual compaction counting fix + cli cleanup (#5480)
  chore(deps): bump prismjs and react-syntax-highlighter in /ui/desktop (#5549)
  fix: remove qwen3-coder from provider/mcp smoke tests (#5551)
  fix: do not build unsigned desktop app bundles on every PR in ci. add manual option. (#5550)
  ...
fbalicchia pushed a commit to fbalicchia/goose that referenced this pull request Nov 7, 2025
BlairAllan pushed a commit to BlairAllan/goose that referenced this pull request Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants