Fix: Always show autocompact threshold ui

[katzdave]

This does duplicate the default threshold in the UI, but I think that's fine since it's so easy to change there (if it actually can render).

[Copilot]

Pull Request Overview

This PR fixes an issue where the autocompact threshold UI would not render when alert.autoCompactThreshold was undefined. The fix ensures the UI is always visible by providing a default fallback value of 0.8 (80%).

Key changes:

• Added a default fallback value of 0.8 to currentThreshold when both loadedThreshold and alert.autoCompactThreshold are null/undefined
• Removed the conditional wrapper that previously prevented the UI from rendering when currentThreshold was undefined

[Copilot]

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

[Copilot]

The ternary check for currentThreshold was removed, but currentThreshold can now be 0.8 by default. If this is the intended behavior, consider that the previous code had a safety check (currentThreshold ? Math.round(currentThreshold * 100) : 80). Without it, if currentThreshold were somehow 0 or falsy, Math.round(currentThreshold * 100) would yield 0, which violates the min constraint of 1. However, since line 53 ensures currentThreshold is always at least 0.8, this is likely safe—but verify that loadedThreshold can never be 0.

Suggested change

	const resetValue = Math.round(currentThreshold * 100);
	const resetValue = currentThreshold ? Math.round(currentThreshold * 100) : 80;

[DOsinga]

can we just make loadedThreshold not optional and initialize to 0.8? also delete autoCompactThreshold, it doesn't seem like we're using it (maybe we used to and that's how this broke?)

[katzdave]

Done. I am still keeping threshold value + loadedThreshold. This lets the value sync across multiple goose windows if it changes (pretty important since the auto-compact will trigger based on the config value).