fix: move goosehints/AGENTS.md handling to goose, and out of developer extension

[alexhancock]

Move .goosehints and AGENTS.md etc handling out of the developer extension and into goose itself. This shouldn't depend on an extension being active to work.

This works at present, but I want to take a few revs on the the new code before merge.

[Copilot]

Pull Request Overview

This PR refactors the hints/goosehints loading functionality by moving it from the goose-mcp crate to the main goose crate, making it available for use in the core agent system. The hints are now loaded dynamically during agent reply preparation rather than being included in MCP server initialization.

Key changes:

• Moved hints module from goose-mcp/src/developer/goose_hints to goose/src/hints
• Updated to use Paths::in_config_dir() for consistent path resolution instead of shellexpand::tilde
• Integrated hints loading into Agent::prepare_tools_and_prompt() based on working directory
• Updated hint message text to be more user-centric

Reviewed Changes

Copilot reviewed 9 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
crates/goose/src/lib.rs	Adds public hints module to the goose crate
crates/goose/src/hints/mod.rs	New module definition exposing hints functionality
crates/goose/src/hints/load_hints.rs	Moved from goose-mcp, updated to use Paths API for config directory resolution
crates/goose/src/hints/import_files.rs	Moved from goose-mcp, handles file reference parsing and expansion in hint files
crates/goose/src/agents/reply_parts.rs	Updated to accept working_dir parameter and load hints during prompt preparation
crates/goose/src/agents/agent.rs	Threads working_dir through to prepare_tools_and_prompt()
crates/goose/Cargo.toml	Adds ignore crate dependency for gitignore pattern handling
crates/goose-mcp/src/developer/rmcp_developer.rs	Removes hints loading from MCP server initialization
crates/goose-mcp/src/developer/mod.rs	Removes goose_hints module reference
crates/goose-mcp/src/developer/goose_hints/mod.rs	File deleted (moved to goose crate)
Cargo.lock	Updates dependency lock file

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The fallback logic is flawed: if GitignoreBuilder::new(working_dir).build() fails on line 95-96, calling it again with the same parameters on lines 99-100 will likely fail for the same reason. The expect() will panic instead of providing a graceful fallback. Consider using a truly empty gitignore as fallback, such as GitignoreBuilder::new(\".\").build().unwrap_or_else(|_| panic!(\"...))`.

Suggested change

	// Fallback to empty gitignore if building fails
	GitignoreBuilder::new(working_dir)
	.build()
	.expect("Failed to create fallback gitignore")
	// Fallback to truly empty gitignore if building fails
	GitignoreBuilder::new(".")
	.build()
	.expect("Failed to create empty fallback gitignore")

[Copilot]

The hint filenames are hardcoded here. Consider extracting these to a constant or making them configurable to maintain consistency with how they were previously configurable via CONTEXT_FILE_NAMES environment variable in the MCP version.

[Copilot]

Pull Request Overview

Copilot reviewed 8 out of 10 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[DOsinga]

serial doesn't protect you; it just means that this test will run serial with all the other serial tests. we're changing the current directory here, so that will make other tests flaky. do we need to change the current directory?

[DOsinga]

no need to check 2 lines for each file (or even inject two lines)

[DOsinga]

should comments that cover the asserts

[DOsinga]

delete this test please

[DOsinga]

delete

[DOsinga]

why are we creating this directory? we're just reading from it?

[DOsinga]

I don't think we should do this in reply_internal - that one is big enough as is. instead add this functionality to the prompt-manager itself and then add it to the call to the prompt manager:

    let prompt_manager = self.prompt_manager.lock().await;
    let system_prompt = prompt_manager
        .builder(model_name)
        .with_extensions(extensions_info.into_iter())
        .with_frontend_instructions(self.frontend_instructions.lock().await.clone())
        .with_extension_and_tool_counts(extension_count, tool_count)
        .build();

[Copilot]

Pull Request Overview

Copilot reviewed 12 out of 14 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

crates/goose/src/hints/load_hints.rs:298

• The test content for README.md was simplified, removing 'Project overview content', but the corresponding assertion checking for this content was also removed (line 318 in the diff). This change reduces test coverage as it no longer verifies that multi-line file content is properly included when expanded. Consider restoring the original test content to maintain more comprehensive test coverage of the file expansion functionality.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.