Update prompt injection detection metrics (due to errors exporting to datadog)

[dorien-koelemeijer]

Summary

There were errors exporting metrics to Datadog, although local testing didn't cause any issues which makes it harder to troubleshoot. Suspicion is that the issues may be due to formatted string messages with {} placeholders, gauge.goose.* as attribute keys, newlines in explanation strings, or emojis in message strings.

Part of error log (not super descriptive):

Field | Value
-- | --
attributes.message | Failed to export metrics
attributes.reason | Metrics exporter otlp failed with http request failed with error sending request for url (xxx)

Type of Change

• Feature
• Bug fix
• Refactor / Code quality
• Performance improvement
• Documentation
• Tests
• Security fix
• Build / Release
• Other (specify below)

AI Assistance

No AI assistance on this PR

Testing

Manual testing - I set up a local Docker OTLP collector to capture and inspect the raw metric payloads from goose, which allowed me to verify that the prompt injection metrics were emitted correctly (along with looking at the already existing metrics).

[Copilot]

Pull Request Overview

This PR attempts to fix Datadog metrics export errors by removing problematic elements from log messages: format string placeholders with {}, gauge.goose.* metric keys, newlines in explanation strings, and emojis.

Key changes:

• Converted gauge.goose.* metrics to counter.goose.*
• Sanitized explanation strings to replace newlines with " | " for metrics
• Simplified log messages to remove format placeholders in some locations

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
crates/goose/src/security/mod.rs	Changed gauge metrics to counters, added explanation sanitization for metrics, and partially simplified log messages (but emojis and some format placeholders remain)
crates/goose/src/agents/tool_execution.rs	Removed format placeholders from user decision logging, converted to structured logging with fields

Comments suppressed due to low confidence (1)

crates/goose/src/security/mod.rs:102

• The log message still uses a format placeholder with "{}" on line 97 and contains emojis (🔒) on lines 99 and 101. According to the PR description, both format placeholders and emojis may be causing Datadog export errors and should be removed.

                        "{}",
                        if above_threshold {
                            "🔒 Current tool call flagged as malicious after security analysis (above threshold)"
                        } else {
                            "🔒 Security finding below threshold - logged but not blocking execution"
                        }