-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Next camp refactor live #5706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next camp refactor live #5706
Conversation
* 'main' of github.com:block/goose: Fix: Always show autocompact threshold ui (#5701) chore: Update governance to include Discord (#5690) Ollama improvements (#5609) feat: add Supabase MCP server to registry (#5629) Unlist VS Code extension tutorials from MCP and experimental sections (#5677) fix: make image processing work in github copilot provider (#5687) fix: do not take into account gitignore in developer mcp (#5688) docs: session storage migration (#5682) New maintainers (#5685) chore: Update governance (#5660) chore(release): release version 1.14.0 (minor) (#5676)
| sessionId: string; | ||
| onStreamFinish: () => void; | ||
| initialMessage?: string; | ||
| onSessionLoaded?: () => void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved initialMessage to BaseChat for better separation of concerns and better control of over when submission happens at the component level. Added onSessionLoaded callback to avoid race conditions by detecting when the session is actually done loading.
| recipeAccepted, | ||
| initialPrompt, | ||
| toolCount, | ||
| autoSubmit = false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no more autoSubmit in this component, its now handled by BaseChats useEffect now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hiep hiep hoera!
* 'main' of github.com:block/goose: docs: removing double announcements (#5714) docs: mcp sampling support (#5708) hackathon banner (#5710) Fix documentation-only change detection for push events (#5712) Added transaction commits to multi sql functions in session_manager (#5693) fix: improve and simplify tool call chain rendering (#5704)
DOsinga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
ui/desktop/src/main.ts
Outdated
| } catch { | ||
| // Leave as-is if decoding fails | ||
| } catch (error) { | ||
| console.error('[Main] parseRecipeDeeplink - Failed to decode:', error); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use errorMessage here
| recipeAccepted, | ||
| initialPrompt, | ||
| toolCount, | ||
| autoSubmit = false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hiep hiep hoera!
|
|
||
| const resumeSessionId = searchParams.get('resumeSessionId') ?? undefined; | ||
| const recipeId = searchParams.get('recipeId') ?? undefined; | ||
| const recipeDeeplinkFromConfig = window.appConfig?.get('recipeDeeplink') as string | undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is still a scary mess, but we should probably clean this up in a separate PR.
I think we should remove chat as a tab in app - I think it causes us a lot of problems here since if you go there it is always unclear if you want to see the most recently loaded chat or do a new one. in a true multi chat world that state can't exist
* main: (48 commits) [fix] generic check for gemini compat (#5842) Add scheduler to diagnostics (#5849) Cors and token (#5850) fix sessions coming back with empty messages (#5841) markdown export from URL (#5830) Next camp refactor live (#5706) Add out of context compaction test via error proxy (#5805) fix: Add backward compatibility for conversationCompacted message type (#5819) Add /agent/stop endpoint, make max active agents configurable (#5826) Handle 404s (#5791) Persist provider name and model config in the session (#5419) Comment out the flaky mcp callers (#5827) Slash commands (#5718) fix: remove setx calls to not permanently edit the windows shell PATH (#5821) fix: Parse maas models for gcp vertex provider (#5816) fix: support Gemini 3's thought signatures (#5806) chore: Add Adrian Cole to Maintainers (#5815) [MCP-UI] Proxy and Better Message Handling (#5487) Release 1.15.0 Document New Window menu in macOS dock (#5811) ...
Signed-off-by: Sai Karthik <[email protected]>
Signed-off-by: Blair Allan <[email protected]>
Summary
Follow up to release next camp refactoring efforts removing ALPHA flag condition and related cleanup.
This enables launching sessions and recipes in the same window along with various refactors to improve how we load chats on the front end.
closes #4980