Skip to content

Conversation

@jojochuang
Copy link
Contributor

What changes were proposed in this pull request?

HDDS-10573. [hsync] Add a freon tool to benchmark hsync/write concurrency.

Please describe your PR in detail:

Related to HDDS-9844. We should have a simple tool that does what HBase WAL do: a writer thread to write into output stream buffer, and a thread pool of threads that do hsync non-stop.

Running a full suite of HBase and ycsb is too clunky. A simple tool can help us iterate fast.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-10573

How was this patch tested?

Unit test

@jojochuang jojochuang requested a review from smengcl March 22, 2024 22:44
@jojochuang jojochuang added the hbase HBase on Ozone support label Mar 25, 2024
Cyrill and others added 7 commits March 25, 2024 20:08
Conflicts:
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockInputStream.java
hadoop-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/BlockInputStreamFactoryImpl.java
hadoop-hdds/client/src/test/java/org/apache/hadoop/hdds/scm/storage/DummyBlockInputStream.java
hadoop-hdds/client/src/test/java/org/apache/hadoop/hdds/scm/storage/TestBlockInputStream.java
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/KeyInputStream.java
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmMetrics.java
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestChunkStreams.java
YuanbenWang and others added 26 commits May 23, 2024 11:57
… does hsync nonstop.

Change-Id: I27d72c4412fe47cf862691515dd0f5fc98623a33
Change-Id: Ie44fa1518a171b70782035d0af0d79a455439954
Wait for future on other unrelated call paths.

Handle null future in `flush()`, `close()`

Undo unintended test change.

Desync `write()` / `close()`.

Wait for non-HSYNC StreamAction in `handleFlushOrClose` for now since they are not returning the future, at least for now.

Culprit of test failure could be premature `watchForCommit`?

This should fix the UT.

findbugs

Fix NPE.

Fix NPE in hsync()

(cherry picked from commit 6dea96e23f6934707024bcf56acddd4a9714b6f5)
(cherry picked from commit 8b87c905b2d6ae7e86d0e2200fbd398a2f2bc82f)
Change-Id: I832bfe4279ff36ad18631f55a1813e570e6f4aa1
Change-Id: I88904c9ce03dc30c77a1d382e238da485d53150a
Change-Id: I541b5d73b7761192cc6f61c2a85214601c37acf3
Change-Id: I7e3e4ad69825dd4872a5201a46109b847764acdf
@jojochuang
Copy link
Contributor Author

Superseded by #6925 so close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hbase HBase on Ozone support

Projects

None yet

Development

Successfully merging this pull request may close these issues.