-
Notifications
You must be signed in to change notification settings - Fork 588
HDDS-10578. Clean up Hadoop dependencies #6432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-10578. Clean up Hadoop dependencies #6432
Conversation
adoroszlai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @myskov for the cleanup. I think some more hadoop dependencies can be removed, but otherwise LGTM.
pom.xml
Outdated
| <groupId>org.apache.hadoop</groupId> | ||
| <artifactId>hadoop-client-api</artifactId> | ||
| <version>${hadoop.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one is also unused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the patch, removed this one
| <artifactId>hadoop-mapreduce-client-jobclient</artifactId> | ||
| <version>${hadoop.version}</version> | ||
| <type>test-jar</type> | ||
| </dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hadoop-mapreduce-client-jobclient is used by integration-test module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Root POM defines two similar dependencies:
Lines 376 to 386 in 0a405d7
| <dependency> | |
| <groupId>org.apache.hadoop</groupId> | |
| <artifactId>hadoop-mapreduce-client-jobclient</artifactId> | |
| <version>${hadoop.version}</version> | |
| </dependency> | |
| <dependency> | |
| <groupId>org.apache.hadoop</groupId> | |
| <artifactId>hadoop-mapreduce-client-jobclient</artifactId> | |
| <version>${hadoop.version}</version> | |
| <type>test-jar</type> | |
| </dependency> |
but only one of them is used (the one without <type>test-jar):
ozone/hadoop-ozone/integration-test/pom.xml
Lines 207 to 211 in 0a405d7
| <dependency> | |
| <groupId>org.apache.hadoop</groupId> | |
| <artifactId>hadoop-mapreduce-client-jobclient</artifactId> | |
| <scope>test</scope> | |
| <exclusions> |
adoroszlai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @myskov for updating the patch.
|
Thanks @kerneltime and @kerneltime for reviewing the patch |
(cherry picked from commit 80bafd0)
What changes were proposed in this pull request?
HDDS-10578. Clean up Hadoop dependencies
There are a lot of Hadoop dependencies, and a significant portion of them are now obsolete.
I removed unused dependencies.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10578
How was this patch tested?
Existing tests