HDDS-10925. [hsync] Parameterize TestBlockOutputStream on ozone.client.stream.putblock.piggybacking #6750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t.stream.putblock.piggybacking Change-Id: I115b06120912d1857390dd3ee9dd706a55458c77
Change-Id: Ibabb8f74562d02e91f5e0dee4618f8248968860f
Change-Id: I065097cfbd8a7056d730e1becae65c540ebcf8c9
smengcl
approved these changes
May 29, 2024
Contributor
smengcl
left a comment
smengcl
left a comment
There was a problem hiding this comment.
lgtm
@jojochuang How long does each param set take in each test suite? I wonder how much the extra param sets have lengthened the whole test suite.
Contributor
Author
|
TestBlockOutputStream is fine but TestBlockOutputStreamWithFailures takes much more (a few more minutes) |
Contributor
Author
|
Merged. Thanks @smengcl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-10925. [hsync] Parameterize TestBlockOutputStream on ozone.client.stream.putblock.piggybacking
Please describe your PR in detail:
Improve BlockOutputStream test coverage for both ozone.client.stream.putblock.piggybacking = true and false.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10925
How was this patch tested?
This is a test only PR.