HDDS-10547. Fix the buffer for the datanode checksum calculation #6402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
Mar 19, 2024
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @Cyrill for the patch.
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java
Outdated
Show resolved
Hide resolved
szetszwo
reviewed
Mar 22, 2024
| if (validateChunkChecksumData) { | ||
| try { | ||
| Checksum.verifyChecksum(data, info.getChecksumData(), 0); | ||
| Checksum.verifyChecksum(data.toByteString(byteBufferToByteString), info.getChecksumData(), 0); |
Contributor
There was a problem hiding this comment.
Please use as below. The toByteString may have buffer copying.
data = data.duplicate(data.position(), data.limit());
szetszwo
approved these changes
Mar 25, 2024
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Contributor
smitajoshi12
pushed a commit
to smitajoshi12/ozone
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-10547. Fix the buffer for the datanode checksum calculation
Datanode chunk checksum validation was broken.
computeChecksum code and chunkWrite code shared the same byte buffer, hence the first one to read from the buffer succeeds and the second attempt to read fails as the buffer position is at the end.
Apparently there are no tests to check that. I returned back the previous code to make it work.
There are three places where
validateChunkChecksumDatais called. I added a unit test to check all three. Also I had to changehandlePutSmallFilemethod as it didn't work correctly even with the checksum buffer fix.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10547
How was this patch tested?
Unit tests.