HDDS-10553. Add test case for creating file with EC replication config #6405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… config by ofs/o3fs
adoroszlai
reviewed
Mar 19, 2024
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @YuanbenWang for the patch.
Comment on lines
435
to
447
| Path root = new Path("/" + volumeName + "/" + bucketName); | ||
| Path testKeyPath = new Path(root, "testKey"); | ||
| conf.set(OZONE_REPLICATION, "rs-3-2-1024k"); | ||
| conf.set(OZONE_REPLICATION_TYPE, "EC"); | ||
| FileSystem fileSystem = FileSystem.get(conf); | ||
| ContractTestUtils.touch(fileSystem, testKeyPath); | ||
|
|
||
| OzoneKeyDetails key = getKey(testKeyPath, false); | ||
| assertEquals(HddsProtos.ReplicationType.EC, | ||
| key.getReplicationConfig().getReplicationType()); | ||
| assertEquals("rs-3-2-1024k", | ||
| key.getReplicationConfig().getReplication()); | ||
| fileSystem.close(); |
Contributor
There was a problem hiding this comment.
Please move the implementation to a new method in OzoneFileSystemTests and call that from both test classes, to avoid code duplication.
| void init() throws Exception { | ||
| OzoneConfiguration conf = new OzoneConfiguration(); | ||
| conf = new OzoneConfiguration(); | ||
| conf.set("fs.o3fs.impl.disable.cache", "true"); |
Contributor
There was a problem hiding this comment.
Please disable the cache only in the specific test case that needs new FileSystem with changed config, similar to:
Contributor
Author
|
@adoroszlai Thanks for your suggestions~! I have updated my code. Could you plz review it? |
adoroszlai
reviewed
Mar 20, 2024
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @YuanbenWang for updating the patch.
...gration-test/src/test/java/org/apache/hadoop/fs/ozone/AbstractRootedOzoneFileSystemTest.java
Show resolved
Hide resolved
...op-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/OzoneFileSystemTests.java
Outdated
Show resolved
Hide resolved
...op-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/OzoneFileSystemTests.java
Outdated
Show resolved
Hide resolved
...op-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/OzoneFileSystemTests.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@adoroszlai Thanks for the review~! I have updated my code again. Could you plz review it? |
This reverts commit c9ef5bd.
adoroszlai
changed the title
adoroszlai
approved these changes
Mar 24, 2024
Contributor
|
Thanks @YuanbenWang for the patch. |
Contributor
Author
|
@adoroszlai Thank you for the review. |
smitajoshi12
pushed a commit
to smitajoshi12/ozone
that referenced
this pull request
Mar 27, 2024
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
May 29, 2024
apache#6405) (cherry picked from commit b267a57)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ofs/o3fs is able to write keys/files with EC replication config, but there is no unit test and doc to explain how to do it. So this pr makes it.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10553
How was this patch tested?
Unit Test
Tested locally.
hadoop client write:
key info: