HDDS-10564. Make Outputstream writeExecutor daemon threads. #6418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Id5a1d332f8ac93991fd52b85ad186cbc6af9630f
Contributor
|
It looks like the |
Contributor
Does that mean ongoing write may be dropped and data lost? |
Contributor
Author
writeExecutor was added by HDDS-10383 and is new. |
Contributor
Author
output stream should call close() which will ensure data in the buffer is flushed. |
adoroszlai
approved these changes
Mar 24, 2024
Contributor
|
Thanks @jojochuang for the patch, @xichen01 for the review. |
smitajoshi12
pushed a commit
to smitajoshi12/ozone
that referenced
this pull request
Mar 27, 2024
jojochuang
added a commit
that referenced
this pull request
Apr 1, 2024
(cherry picked from commit 82c02d3)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Apr 11, 2024
) (cherry picked from commit 82c02d3)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Apr 11, 2024
) (cherry picked from commit 82c02d3)
xichen01
pushed a commit
that referenced
this pull request
Apr 16, 2024
(cherry picked from commit 82c02d3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-10564. Make Outputstream writeExecutor daemon threads.
Please describe your PR in detail:
HDDS-10383 added new thread pools in the output stream. They should be made daemon threads so that processes don't wait for them when exiting. (The bug is in the command line which does not close FileSystem object. Nonetheless, it would still be a good idea to make these thread pools daemon)
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10564
How was this patch tested?
Deployed on a real cluster, with HBase on Ozone, repeated the same command to verify that the command no longer hangs.