HDDS-10510. Improve user experience with containerbalancer CLI #6433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@SaketaChalamchala please review this patch. |
adoroszlai
reviewed
Mar 25, 2024
...hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/ContainerBalancerStopSubcommand.java
Outdated
Show resolved
Hide resolved
tanvipenumudy
approved these changes
Mar 26, 2024
Contributor
tanvipenumudy
left a comment
tanvipenumudy
left a comment
There was a problem hiding this comment.
Thank you @sarvekshayr for the patch.
+1 pending CI report.
siddhantsangwan
approved these changes
Mar 26, 2024
Contributor
siddhantsangwan
left a comment
siddhantsangwan
left a comment
There was a problem hiding this comment.
@sarvekshayr Thanks for the update. LGTM, pending green CI.
Contributor
|
Thanks @sarvekshayr for the patch, @SaketaChalamchala, @siddhantsangwan, @tanvipenumudy, @Tejaskriya for the review. |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
May 29, 2024
(cherry picked from commit d03f68f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ozone admin containerbalancer stopcommand seems stuck and does not return anything while it is in STOPPING state waiting for the current iteration to complete.Print progress message to improve the logs for containerbalancer CLI.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10510
How was this patch tested?
Manually tested this patch using a docker cluster. Also got a clean CI run.