Skip to content

HDDS-10583. Thread name prefix in ReplicationSupervisor is null #6430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adoroszlai merged 1 commit into from
Mar 25, 2024
Merged

HDDS-10583. Thread name prefix in ReplicationSupervisor is null #6430

adoroszlai merged 1 commit into from
Mar 25, 2024

Conversation

@adoroszlai
Copy link
Contributor

@adoroszlai adoroszlai commented Mar 24, 2024

What changes were proposed in this pull request?

ReplicationSupervisor#Builder#threadNamePrefix is never called, prefix is null:

2024-03-24 12:17:18,388 [nullContainerReplicationThread-0] INFO reconstruction.ECReconstructionCoordinatorTask: IN_PROGRESS reconstructECContainersCommand ...

Fix it by using threadNamePrefix from StateContext, remove unnecessary variable from ReplicationSupervisor#Builder.

https://issues.apache.org/jira/browse/HDDS-10583

How was this patch tested?

$ mvn clean test -Dtest='TestECContainerRecovery,TestReconAndAdminContainerCLI'
...

$ grep -m1 ContainerReplicationThread hadoop-ozone/integration-test/target/surefire-reports/*txt

hadoop-ozone/integration-test/target/surefire-reports/org.apache.hadoop.ozone.recon.TestReconAndAdminContainerCLI-output.txt
2024-03-24 13:39:15,367 [0e4795b1-1dfe-4ad0-8460-f5f86ed0131d-ContainerReplicationThread-0] INFO  replication.PushReplicator (PushReplicator.java:replicate(58)) - Starting replication of container 1 ...

hadoop-ozone/integration-test/target/surefire-reports/org.apache.hadoop.ozone.container.TestECContainerRecovery-output.txt
2024-03-24 13:40:19,646 [0d3b1861-d867-40cd-988f-80f5fb631379-ContainerReplicationThread-0] INFO  reconstruction.ECReconstructionCoordinatorTask (ECReconstructionCoordinatorTask.java:runTask(65)) - IN_PROGRESS reconstructECContainersCommand: ...

CI:
https://github.com/adoroszlai/ozone/actions/runs/8409345087

@adoroszlai adoroszlai self-assigned this Mar 24, 2024
@adoroszlai adoroszlai requested a review from devmadhuu March 25, 2024 12:35
devmadhuu
devmadhuu approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@devmadhuu devmadhuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adoroszlai for the patch. LGTM +1

@adoroszlai adoroszlai merged commit 07a68c0 into apache:master Mar 25, 2024
@adoroszlai adoroszlai deleted the HDDS-10583 branch March 25, 2024 15:25
@adoroszlai
Copy link
Contributor Author

adoroszlai commented Mar 25, 2024

Thanks @devmadhuu for the review.

smitajoshi12 pushed a commit to smitajoshi12/ozone that referenced this pull request Mar 27, 2024
@adoroszlai @smitajoshi12
HDDS-10583. Thread name prefix in ReplicationSupervisor is null (apac…
0861a6f 
…he#6430)
myskov pushed a commit to myskov/ozone that referenced this pull request Apr 4, 2024
@adoroszlai
HDDS-10583. Thread name prefix in ReplicationSupervisor is null (apac…
030a43a 
…he#6430)

(cherry picked from commit 07a68c0)
@myskov myskov mentioned this pull request Apr 4, 2024
Merged
jojochuang pushed a commit to jojochuang/ozone that referenced this pull request May 29, 2024
@adoroszlai
HDDS-10583. Thread name prefix in ReplicationSupervisor is null (apac…
954f7e6 
…he#6430)

(cherry picked from commit 07a68c0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devmadhuu devmadhuu devmadhuu approved these changes

Assignees

@adoroszlai adoroszlai

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adoroszlai @devmadhuu