-
Notifications
You must be signed in to change notification settings - Fork 593
HDDS-10118. hdds-rocks-native fails to build with Java11+ #6415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like the original issue has been fixed (probably by HDDS-10149) since it was reported. The patch fixes another problem @raju-balpande found: |
swamirishi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raju-balpande Thanks for the patch LGTM
| <argument>${project.build.directory}/native/javah</argument> | ||
| <argument>${project.basedir}/src/main/java/org/apache/hadoop/hdds/utils/db/managed/ManagedRawSSTFileReader.java</argument> | ||
| <argument>${project.basedir}/src/main/java/org/apache/hadoop/hdds/utils/db/managed/ManagedRawSSTFileReaderIterator.java</argument> | ||
| <argument>${project.basedir}/src/main/java/org/apache/hadoop/hdds/utils/db/managed/ManagedRawSSTFileIterator.java</argument> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my bad ! Missed this in my previous commit. @raju-balpande Thanks for pointing this out.
|
Thanks @raju-balpande for the patch, @swamirishi for the review. |
…apache#6415) Change-Id: I7416a37af13ab3e27233f4d0e289c5d484ae19da
What changes were proposed in this pull request?
Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.0.2:copy-dependencies (copy-jars) on project hdds-rocks-native: Artifact has not been packaged yet. When used on reactor artifact, copy should be executed after packaging: see MDEP-187.
I found the file names mismatch in the the referred directory
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10118
How was this patch tested?
Tested with command line
alias mvn11="JAVA_HOME=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home && mvn"
mvn11 clean install -DskipTests -e -DskipShade -X -Drocks_tools_native