Skip to content

Conversation

@raju-balpande
Copy link
Contributor

What changes were proposed in this pull request?

Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.0.2:copy-dependencies (copy-jars) on project hdds-rocks-native: Artifact has not been packaged yet. When used on reactor artifact, copy should be executed after packaging: see MDEP-187.

I found the file names mismatch in the the referred directory

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-10118

How was this patch tested?

Tested with command line
alias mvn11="JAVA_HOME=/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home && mvn"
mvn11 clean install -DskipTests -e -DskipShade -X -Drocks_tools_native

@kerneltime kerneltime requested a review from swamirishi March 21, 2024 17:26
@adoroszlai
Copy link
Contributor

It looks like the original issue has been fixed (probably by HDDS-10149) since it was reported. The patch fixes another problem @raju-balpande found:

[INFO] --- maven-dependency-plugin:3.6.1:copy-dependencies (copy-jars) @ hdds-rocks-native ---
[INFO] Copying hdds-managed-rocksdb-1.5.0-SNAPSHOT.jar to hadoop-hdds/rocks-native/target/dependency/hdds-managed-rocksdb-1.5.0-SNAPSHOT.jar
[INFO] Copying hdds-common-1.5.0-SNAPSHOT.jar to hadoop-hdds/rocks-native/target/dependency/hdds-common-1.5.0-SNAPSHOT.jar
[INFO] Copying hdds-hadoop-dependency-client-1.5.0-SNAPSHOT.jar to hadoop-hdds/rocks-native/target/dependency/hdds-hadoop-dependency-client-1.5.0-SNAPSHOT.jar
[INFO] Copying hadoop-annotations-3.3.6.jar to hadoop-hdds/rocks-native/target/dependency/hadoop-annotations-3.3.6.jar
...
[INFO] --- exec-maven-plugin:3.1.1:exec (javach) @ hdds-rocks-native ---
error: file not found: hadoop-hdds/rocks-native/src/main/java/org/apache/hadoop/hdds/utils/db/managed/ManagedRawSSTFileReaderIterator.java
Usage: javac <options> <source files>
use --help for a list of possible options
19:17:56,727 [ERROR] Command execution failed.
org.apache.commons.exec.ExecuteException: Process exited with an error: 2 (Exit value: 2)

Copy link
Contributor

@swamirishi swamirishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raju-balpande Thanks for the patch LGTM

<argument>${project.build.directory}/native/javah</argument>
<argument>${project.basedir}/src/main/java/org/apache/hadoop/hdds/utils/db/managed/ManagedRawSSTFileReader.java</argument>
<argument>${project.basedir}/src/main/java/org/apache/hadoop/hdds/utils/db/managed/ManagedRawSSTFileReaderIterator.java</argument>
<argument>${project.basedir}/src/main/java/org/apache/hadoop/hdds/utils/db/managed/ManagedRawSSTFileIterator.java</argument>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my bad ! Missed this in my previous commit. @raju-balpande Thanks for pointing this out.

@adoroszlai adoroszlai merged commit 97038ef into apache:master Mar 21, 2024
@adoroszlai
Copy link
Contributor

Thanks @raju-balpande for the patch, @swamirishi for the review.

smitajoshi12 pushed a commit to smitajoshi12/ozone that referenced this pull request Mar 27, 2024
swamirishi pushed a commit to swamirishi/ozone that referenced this pull request Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants