HDDS-10143. Fix intermittent failure in testParallelDeleteBucketAndCreateKey #6335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
Mar 6, 2024
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @xichen01 for the patch.
| thread2.start(); | ||
| Thread.sleep(2000); | ||
| // Wait long enough for createKey's preExecute to finish executing | ||
| Thread.sleep(10000); |
Contributor
There was a problem hiding this comment.
Can we change this to waitFor some explicit condition?
Contributor
Author
There was a problem hiding this comment.
Yes, but this needs to modify more codes. We need to know the preExecture has been executed completely, but the preExecture is a prviate method (or we need to add some flag to watch), I don't want ot modify it just for only one testing.
Add sleeping time is a dirty but quick solution. How do you think?
adoroszlai
approved these changes
Mar 24, 2024
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @xichen01 for updating the patch.
Latest repeated run for reference:
https://github.com/xichen01/ozone/actions/runs/8358073042
smitajoshi12
pushed a commit
to smitajoshi12/ozone
that referenced
this pull request
Mar 27, 2024
…arallelDeleteBucketAndCreateKey (apache#6335)
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
May 29, 2024
…arallelDeleteBucketAndCreateKey (apache#6335) (cherry picked from commit f9e5178)
xichen01
added a commit
to xichen01/ozone
that referenced
this pull request
Oct 1, 2024
…arallelDeleteBucketAndCreateKey (apache#6335) (cherry picked from commit f9e5178)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix testParallelDeleteBucketAndCreateKey
The root cause is the
preExecute#resolveBucketAndCheckKeyAclsofCreateKeymay execute afterdeleteBucket, then theCreateKey#preExecutewill throw an exception, so the test will fail. For fix this, we just need to add the waiting time.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10143
How was this patch tested?
Before, lots of failures.
https://github.com/xichen01/ozone/actions/runs/8158284595
After, All successful
https://github.com/xichen01/ozone/actions/runs/8158363756