Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

summary.txt for checkstyle incorrectly removes failure message that matches the string xml, e.g. unused import from com.fasterxml.jackson.

checkstyle-errors.xml:

<file name="hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/tenant/GetUserInfoHandler.java">
<error line="20" column="8" severity="error" message="Unused import - com.fasterxml.jackson.databind.ObjectMapper." source="com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck"/>
</file>

summary.txt:

hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/tenant/GetUserInfoHandler.java

The problem is that <\?xml matches <xml or xml instead of <?xml as intended.

https://issues.apache.org/jira/browse/HDDS-10556

How was this patch tested?

Checked out ArafatKhan2198@9d4b3e5, ran checkstyle:

$ ./hadoop-ozone/dev-support/checks/checkstyle.sh
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/tenant/GetUserInfoHandler.java
 20: Unused import - com.fasterxml.jackson.databind.ObjectMapper.

@adoroszlai adoroszlai added the CI label Mar 20, 2024
@adoroszlai adoroszlai self-assigned this Mar 20, 2024
@Galsza
Copy link
Contributor

Galsza commented Mar 21, 2024

Thank you @adoroszlai for the patch LGTM+1

Copy link
Contributor

@myskov myskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the patch @adoroszlai , LGTM

@myskov myskov merged commit 74f04a7 into apache:master Mar 22, 2024
@adoroszlai adoroszlai deleted the HDDS-10556 branch March 22, 2024 12:16
@adoroszlai
Copy link
Contributor Author

Thanks @myskov for reviewing and merging this.

smitajoshi12 pushed a commit to smitajoshi12/ozone that referenced this pull request Mar 27, 2024
jojochuang pushed a commit to jojochuang/ozone that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants