HDDS-10581. NPE in SummarySubCommand & DiskUsageSubCommand. #6429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
.asInt()and.asText()on potentially nullJsonNodeobjects returned by.get(String)when the expected keys were missing in the JSON response..path(String)method followed by.asInt(defaultValue)or.asText(defaultValue)to safely access and convert JSON fields. The.path(String)method ensures a null-safe way to access JSON fields, returning a "missing node" instead of null for absent keys, thereby preventing NPEs. Furthermore, by specifying default values for.asInt(defaultValue)and.asText(defaultValue), we ensured that our code could handle missing or unexpected data gracefully, defaulting to a pre-defined value instead of crashing or behaving unpredictably.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10581
How was this patch tested?
TestNSSummaryAdminwithout a problem.https://github.com/ArafatKhan2198/ozone/actions/runs/8408238070