HDDS-10540. Replace GSON with Jackson in nssummary. #6400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
Mar 19, 2024
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @ArafatKhan2198 for splitting this from #6147.
.../integration-test/src/test/java/org/apache/hadoop/ozone/recon/TestReconWithOzoneManager.java
Outdated
Show resolved
Hide resolved
devmadhuu
reviewed
Mar 21, 2024
Contributor
devmadhuu
left a comment
devmadhuu
left a comment
There was a problem hiding this comment.
Thanks @ArafatKhan2198 for working on this patch, Overall LGTM. Just a minor suggestion. Pls check.
...p-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/nssummary/DiskUsageSubCommand.java
Outdated
Show resolved
Hide resolved
Contributor
|
@ArafatKhan2198 there are checkstyle failures (please do check it before asking for review) |
Contributor
Author
Yes they are fixed! |
adoroszlai
reviewed
Mar 21, 2024
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/server/JsonUtils.java
Outdated
Show resolved
Hide resolved
Contributor
|
Thanks @ArafatKhan2198 for updating the patch. @devmadhuu please take another look |
devmadhuu
reviewed
Mar 22, 2024
Contributor
devmadhuu
left a comment
devmadhuu
left a comment
There was a problem hiding this comment.
Thanks @ArafatKhan2198 for updating the patch. Few comments. Pls check.
...p-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/nssummary/DiskUsageSubCommand.java
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/nssummary/NSSummaryCLIUtils.java
Outdated
Show resolved
Hide resolved
adoroszlai
approved these changes
Mar 24, 2024
Contributor
|
Thanks @ArafatKhan2198 for the patch, @devmadhuu for the review. |
smitajoshi12
pushed a commit
to smitajoshi12/ozone
that referenced
this pull request
Mar 27, 2024
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
May 29, 2024
(cherry picked from commit 1ceec5c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This update addresses compatibility concerns with Java 17 by transitioning from GSON to Jackson in the
NSSummarycode. This change simplifies dependencies and ensures smooth operation across different Java versions.Parent Jira Issue: HDDS-10538
This patch streamlines our Subcommands Implementation.
Affected NSSummary-Subcommands Classes:
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10540
How was this patch tested?
The existing UT's passed successfully.
And the forked CI passed successfully as well.