Skip to content

Add crate publish test to ci#6332

Closed
mircea-c wants to merge 114 commits intoanza-xyz:masterfrom
mircea-c:master
Closed

Add crate publish test to ci#6332
mircea-c wants to merge 114 commits intoanza-xyz:masterfrom
mircea-c:master

Conversation

@mircea-c
Copy link
Copy Markdown

@mircea-c mircea-c commented May 27, 2025

Problem

Publishing crates to crates.io sometimes fails during releases leaving versions in an inconsistent state.

Summary of Changes

Add an extra task to the crate-check workflow which publishes the crates to a test repo.

Closes https://github.com/anza-xyz/devops/issues/299

@yihau
Copy link
Copy Markdown
Member

yihau commented May 28, 2025

if we won't plan to add cron jobs for it, I guess we can put this step into the same place

command_step checks1 "ci/docker-run-default-image.sh ci/test-checks.sh" 20 check
command_step dcou-1-of-3 "ci/docker-run-default-image.sh ci/test-dev-context-only-utils.sh --partition 1/3" 20 check
command_step dcou-2-of-3 "ci/docker-run-default-image.sh ci/test-dev-context-only-utils.sh --partition 2/3" 20 check
command_step dcou-3-of-3 "ci/docker-run-default-image.sh ci/test-dev-context-only-utils.sh --partition 3/3" 20 check
command_step miri "ci/docker-run-default-image.sh ci/test-miri.sh" 5 check
command_step frozen-abi "ci/docker-run-default-image.sh ./test-abi.sh" 15 check

instead of triggering a different pipeline 🤔

@mircea-c mircea-c self-assigned this May 29, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.8%. Comparing base (6b322ca) to head (d8db10b).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #6332     +/-   ##
=========================================
- Coverage    82.8%    82.8%   -0.1%     
=========================================
  Files         847      847             
  Lines      379497   379497             
=========================================
- Hits       314307   314302      -5     
- Misses      65190    65195      +5     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mircea-c mircea-c requested a review from a team as a code owner June 5, 2025 21:18
Comment thread svm/Cargo.toml Outdated
@mergify
Copy link
Copy Markdown

mergify Bot commented Jun 6, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

Copy link
Copy Markdown

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6440 and #6525 both landed so this one can be rebased when you get around to it

mircea-c and others added 20 commits June 12, 2025 14:53
…#6427)

Bumps [solana-program-memory](https://github.com/anza-xyz/solana-sdk) from 2.2.1 to 2.3.0.
- [Release notes](https://github.com/anza-xyz/solana-sdk/releases)
- [Commits](https://github.com/anza-xyz/solana-sdk/compare/sdk@v2.2.1...hash@v2.3.0)

---
updated-dependencies:
- dependency-name: solana-program-memory
  dependency-version: 2.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* CI: Allow warnings on downstream job tests

#### Problem

During the downstream jobs, the patching step also updates crate
versions, causing issues when the updated crate versions have things
like deprecation warnings. See
https://github.com/anza-xyz/agave/actions/runs/15462162384/job/43525772248?pr=6415
for an example.

#### Summary of changes

Since we mainly want to be sure that downstream repos don't break, allow
warnings on the test step.

* Oops, missed v0
add serde feature to banks-interface deps
* scrub use of `ConfigState` from config program client

* review feedback

* use updated interface and client libs

* Update Cargo.toml

Co-authored-by: Jon C <me@jonc.dev>

* Update Cargo.toml

Co-authored-by: Jon C <me@jonc.dev>

---------

Co-authored-by: Jon C <me@jonc.dev>
* ci: install cargo-sort v2

* cargo sort
* build(deps): bump reqwest from 0.12.16 to 0.12.19

Bumps [reqwest](https://github.com/seanmonstar/reqwest) from 0.12.16 to 0.12.19.
- [Release notes](https://github.com/seanmonstar/reqwest/releases)
- [Changelog](https://github.com/seanmonstar/reqwest/blob/master/CHANGELOG.md)
- [Commits](seanmonstar/reqwest@v0.12.16...v0.12.19)

---
updated-dependencies:
- dependency-name: reqwest
  dependency-version: 0.12.19
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update all Cargo files

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add LTO flag for cargo-build-sbf

* Update platform-tools-sdk/cargo-build-sbf/src/main.rs

Co-authored-by: Fernando Otero <febo@anza.xyz>

* Update lto help descrption

---------

Co-authored-by: Fernando Otero <febo@anza.xyz>
…6317)

* perf: remove redundant BufReaders for decompressing tar archives

* Format

* Switch bzip2 decoder to read
…6408)

* build(deps): bump solana-program-error from 2.2.1 to 2.2.2

Bumps [solana-program-error](https://github.com/anza-xyz/solana-sdk) from 2.2.1 to 2.2.2.
- [Release notes](https://github.com/anza-xyz/solana-sdk/releases)
- [Commits](https://github.com/anza-xyz/solana-sdk/compare/sdk@v2.2.1...sdk@v2.2.2)

---
updated-dependencies:
- dependency-name: solana-program-error
  dependency-version: 2.2.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* bump solana-program-error for platform-tools-sdk/cargo-build-sbf, programs/sbf and svm/example

* impl ToStr instead of PrintProgramError

* bump solana-account-info to 2.3.0

* realloc -> resize

* bump solana-program-entrypoint from 2.2.0 to 2.2.1

* bump solana-pubkey to 2.4.0

* bump solana-package-metadata to 2.2.1

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: yihau <yihau.chen@icloud.com>
add missing features to banks-client crate
@mergify
Copy link
Copy Markdown

mergify Bot commented Jun 12, 2025

If this PR represents a change to the public RPC API:

  1. Make sure it includes a complementary update to rpc-client/ (example)
  2. Open a follow-up PR to update the JavaScript client @solana/kit (example)

Thank you for keeping the RPC clients in sync with the server API @mircea-c.

@mergify
Copy link
Copy Markdown

mergify Bot commented Jun 12, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@mircea-c
Copy link
Copy Markdown
Author

FFS. I messed up a git rebase. Closing this and will push a new PR with the changes 😔

@t-nelson
Copy link
Copy Markdown

new one is here #6550

FWIW, in the future, you can just force push over your feature branch that the pr was created from and github will update the pr as if nothing happened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants