svm: Remove solana-sdk dependency from examples#6304
Merged
steviez merged 1 commit intoanza-xyz:masterfrom May 27, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6304 +/- ##
=======================================
Coverage 82.7% 82.7%
=======================================
Files 845 845
Lines 377824 377824
=======================================
+ Hits 312782 312817 +35
+ Misses 65042 65007 -35 🚀 New features to boost your workflow:
|
|
The examples folder is checked in CI with only |
|
I'm OK merging the PR. We can fix the examples and the CI later. |
LucasSte
approved these changes
May 26, 2025
Merged
mircea-c
pushed a commit
to mircea-c/agave
that referenced
this pull request
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rips out the dependency on
solana-sdk; however, I'm not sure that the examples are currently building in CI. Runningcargo buildin<REPO_ROOT>/svm/examplesyields this error on the tip of master (this goes away if you enable theblake3feature):cargo build output
Moreso, this is an invalid dependency path given that
sdkis no longer in the monorepo:agave/svm/examples/json-rpc/program/Cargo.toml
Line 13 in ae8fe77
This is because
json-rpc-example-programis not listed in themembers:agave/svm/examples/Cargo.toml
Lines 1 to 2 in ae8fe77
For the sake of progressing removal of
solana-sdk, I propose we push these changes as is (assuming CI is happy) and then tackle further cleanup later