CI: Allow warnings on downstream job tests#6428
Merged
joncinque merged 2 commits intoanza-xyz:masterfrom Jun 5, 2025
Merged
Conversation
#### Problem During the downstream jobs, the patching step also updates crate versions, causing issues when the updated crate versions have things like deprecation warnings. See https://github.com/anza-xyz/agave/actions/runs/15462162384/job/43525772248?pr=6415 for an example. #### Summary of changes Since we mainly want to be sure that downstream repos don't break, allow warnings on the test step.
alexpyattaev
approved these changes
Jun 5, 2025
alexpyattaev
left a comment
alexpyattaev
left a comment
There was a problem hiding this comment.
I assume we are coming up with a more permanent solution as per discussion in https://discord.com/channels/428295358100013066/439194979856809985/1380136059354087484
|
The v2.3 CI is also experiencing this issue. I've added the v2.3 label for backporting. |
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
mergify Bot
pushed a commit
that referenced
this pull request
Jun 9, 2025
* CI: Allow warnings on downstream job tests #### Problem During the downstream jobs, the patching step also updates crate versions, causing issues when the updated crate versions have things like deprecation warnings. See https://github.com/anza-xyz/agave/actions/runs/15462162384/job/43525772248?pr=6415 for an example. #### Summary of changes Since we mainly want to be sure that downstream repos don't break, allow warnings on the test step. * Oops, missed v0 (cherry picked from commit 347b25d)
brooksprumo
pushed a commit
that referenced
this pull request
Jun 9, 2025
…6469) CI: Allow warnings on downstream job tests (#6428) * CI: Allow warnings on downstream job tests #### Problem During the downstream jobs, the patching step also updates crate versions, causing issues when the updated crate versions have things like deprecation warnings. See https://github.com/anza-xyz/agave/actions/runs/15462162384/job/43525772248?pr=6415 for an example. #### Summary of changes Since we mainly want to be sure that downstream repos don't break, allow warnings on the test step. * Oops, missed v0 (cherry picked from commit 347b25d) Co-authored-by: Jon C <me@jonc.dev>
mircea-c
pushed a commit
to mircea-c/agave
that referenced
this pull request
Jun 12, 2025
* CI: Allow warnings on downstream job tests #### Problem During the downstream jobs, the patching step also updates crate versions, causing issues when the updated crate versions have things like deprecation warnings. See https://github.com/anza-xyz/agave/actions/runs/15462162384/job/43525772248?pr=6415 for an example. #### Summary of changes Since we mainly want to be sure that downstream repos don't break, allow warnings on the test step. * Oops, missed v0
mircea-c
added a commit
to mircea-c/agave
that referenced
this pull request
Jun 12, 2025
* CI: Allow warnings on downstream job tests #### Problem During the downstream jobs, the patching step also updates crate versions, causing issues when the updated crate versions have things like deprecation warnings. See https://github.com/anza-xyz/agave/actions/runs/15462162384/job/43525772248?pr=6415 for an example. #### Summary of changes Since we mainly want to be sure that downstream repos don't break, allow warnings on the test step. * Oops, missed v0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
During the downstream jobs, the patching step also updates crate versions, causing issues when the updated crate versions have things like deprecation warnings. See
https://github.com/anza-xyz/agave/actions/runs/15462162384/job/43525772248?pr=6415 for an example.
Summary of changes
Since we mainly want to be sure that downstream repos don't break, allow warnings on the test step.