Skip to content

Updates snapshot tests to use default archive format#6319

Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo:snap/remove-archive-formats/tests
May 27, 2025
Merged

Updates snapshot tests to use default archive format#6319
brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo:snap/remove-archive-formats/tests

Conversation

@brooksprumo
Copy link
Copy Markdown

Problem

As of v1.18 (solana-labs#33484), TarZstd and TarLz4 are the only valid snapshot archive formats when creating new snapshots (we still allow loading any format though). It is now safe to remove the code that creates archives in the unsupported formats.

For this PR, tests fail if we remove the unsupported formats when creating snapshots. So update the tests first.

Summary of Changes

Snapshot tests that create snapshots use the default archive format.

@brooksprumo brooksprumo self-assigned this May 27, 2025
@brooksprumo brooksprumo marked this pull request as ready for review May 27, 2025 14:17
@brooksprumo brooksprumo requested review from HaoranYi and roryharr May 27, 2025 14:17
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.7%. Comparing base (4b0dc70) to head (99fcc83).
⚠️ Report is 3299 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6319   +/-   ##
=======================================
  Coverage    82.7%    82.7%           
=======================================
  Files         845      845           
  Lines      377724   377724           
=======================================
+ Hits       312732   312740    +8     
+ Misses      64992    64984    -8     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@brooksprumo brooksprumo merged commit 1bfc6ec into anza-xyz:master May 27, 2025
47 checks passed
@brooksprumo brooksprumo deleted the snap/remove-archive-formats/tests branch May 27, 2025 15:40
mircea-c pushed a commit to mircea-c/agave that referenced this pull request Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants