Updates snapshot tests to use default archive format#6319
Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom May 27, 2025
Merged
Updates snapshot tests to use default archive format#6319brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo merged 1 commit intoanza-xyz:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6319 +/- ##
=======================================
Coverage 82.7% 82.7%
=======================================
Files 845 845
Lines 377724 377724
=======================================
+ Hits 312732 312740 +8
+ Misses 64992 64984 -8 🚀 New features to boost your workflow:
|
mircea-c
pushed a commit
to mircea-c/agave
that referenced
this pull request
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As of v1.18 (solana-labs#33484), TarZstd and TarLz4 are the only valid snapshot archive formats when creating new snapshots (we still allow loading any format though). It is now safe to remove the code that creates archives in the unsupported formats.
For this PR, tests fail if we remove the unsupported formats when creating snapshots. So update the tests first.
Summary of Changes
Snapshot tests that create snapshots use the default archive format.