scrub use of ConfigState from config program client#5963
Merged
mergify[bot] merged 5 commits intoanza-xyz:masterfrom Jun 6, 2025
Merged
scrub use of ConfigState from config program client#5963mergify[bot] merged 5 commits intoanza-xyz:masterfrom
ConfigState from config program client#5963mergify[bot] merged 5 commits intoanza-xyz:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5963 +/- ##
=======================================
Coverage 82.8% 82.8%
=======================================
Files 848 847 -1
Lines 379490 379488 -2
=======================================
Hits 314482 314482
+ Misses 65008 65006 -2 🚀 New features to boost your workflow:
|
joncinque
reviewed
Apr 28, 2025
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks good to me! Just a tiny nit.
Once the new config program client crate is available, and the PR is updated to use it, I'll approve.
buffalojoec
force-pushed
the
drop-config-state
branch
from
a923940 to
97b4187
Compare
Author
|
I don't think CI is me... |
|
Hm, looks like it's picking up a newer version of solana-native-token, which is causing those warnings to throw. I put in #6428 to silence the warnings |
joncinque
reviewed
Jun 5, 2025
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Just a few last things to update, then this is good to go!
joncinque
approved these changes
Jun 5, 2025
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks good to me! Will just need a rebase once the CI fix lands
Co-authored-by: Jon C <me@jonc.dev>
Co-authored-by: Jon C <me@jonc.dev>
buffalojoec
force-pushed
the
drop-config-state
branch
from
67ea58e to
29ac55e
Compare
buffalojoec
added
the
automerge
mircea-c
pushed a commit
to mircea-c/agave
that referenced
this pull request
Jun 12, 2025
* scrub use of `ConfigState` from config program client * review feedback * use updated interface and client libs * Update Cargo.toml Co-authored-by: Jon C <me@jonc.dev> * Update Cargo.toml Co-authored-by: Jon C <me@jonc.dev> --------- Co-authored-by: Jon C <me@jonc.dev>
mircea-c
added a commit
to mircea-c/agave
that referenced
this pull request
Jun 12, 2025
* scrub use of `ConfigState` from config program client * review feedback * use updated interface and client libs * Update Cargo.toml Co-authored-by: Jon C <me@jonc.dev> * Update Cargo.toml Co-authored-by: Jon C <me@jonc.dev> --------- Co-authored-by: Jon C <me@jonc.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We're trying to get rid of the
ConfigStatetrait, since it's not super useful. It's also not necessary in Agave at all.Summary of Changes
Scrub all use of
ConfigState, and use the helpers from the config client that only requireserde::Serialize.Note this depends on the linked branch for now, so it's to remain a draft until that lands.