CI - Adds more tests for memops syscalls#6318
Merged
Lichtso merged 1 commit intoanza-xyz:masterfrom May 27, 2025
Merged
Conversation
|
The Firedancer team maintains a line-for-line reimplementation of the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6318 +/- ##
=========================================
- Coverage 82.7% 82.7% -0.1%
=========================================
Files 845 845
Lines 377724 377879 +155
=========================================
+ Hits 312732 312758 +26
- Misses 64992 65121 +129 🚀 New features to boost your workflow:
|
LucasSte
approved these changes
May 27, 2025
mircea-c
pushed a commit
to mircea-c/agave
that referenced
this pull request
Jun 12, 2025
Adds more tests for memops syscalls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We only have tests for the
non_contiguous(usingiter_memory_pair_chunks) version of these syscalls, which become relevant when thebpf_account_data_direct_mappingfeature is active.Summary of Changes
Adds success and failure tests of memcpy, memmove, memcmp, memset in the "normal" contiguous cases (which are expected to fail at memory region boundaries).