Skip to content

CI - Adds more tests for memops syscalls#6318

Merged
Lichtso merged 1 commit intoanza-xyz:masterfrom
Lichtso:ci/test_memops_syscalls
May 27, 2025
Merged

CI - Adds more tests for memops syscalls#6318
Lichtso merged 1 commit intoanza-xyz:masterfrom
Lichtso:ci/test_memops_syscalls

Conversation

@Lichtso
Copy link
Copy Markdown

@Lichtso Lichtso commented May 27, 2025

Problem

We only have tests for the non_contiguous (using iter_memory_pair_chunks) version of these syscalls, which become relevant when the bpf_account_data_direct_mapping feature is active.

Summary of Changes

Adds success and failure tests of memcpy, memmove, memcmp, memset in the "normal" contiguous cases (which are expected to fail at memory region boundaries).

@Lichtso Lichtso requested a review from a team as a code owner May 27, 2025 12:01
@mergify
Copy link
Copy Markdown

mergify Bot commented May 27, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.7%. Comparing base (4b0dc70) to head (1847be8).

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #6318     +/-   ##
=========================================
- Coverage    82.7%    82.7%   -0.1%     
=========================================
  Files         845      845             
  Lines      377724   377879    +155     
=========================================
+ Hits       312732   312758     +26     
- Misses      64992    65121    +129     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Lichtso Lichtso merged commit 0bcd772 into anza-xyz:master May 27, 2025
47 checks passed
@Lichtso Lichtso deleted the ci/test_memops_syscalls branch May 27, 2025 15:50
mircea-c pushed a commit to mircea-c/agave that referenced this pull request Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants