Add feature to svm deps

[mircea-c]

Problem

Publishing this crate fails because of missing features

Summary of Changes

Add debug-signature feature to the dependencies that require it.

Required to fix CI for #6332

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.8%. Comparing base (1ecf042) to head (179f112).
Report is 4 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #6440    +/-   ##
========================================
  Coverage    82.7%    82.8%            
========================================
  Files         851      851            
  Lines      380034   379954    -80     
========================================
+ Hits       314668   314748    +80     
+ Misses      65366    65206   -160     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[LucasSte]

It looks like the feature is only necessary when we build with debug_assertions:

agave/svm/src/transaction_processor.rs

Lines 863 to 864 in 3e58350

	#[cfg(debug_assertions)]
	transaction_context.set_signature(tx.signature());

Would something like this in the toml file work?

[target.'cfg(debug_assertions)'.dependencies]
solana-transaction-context = { workspace = true, features = ["debug-signature"] }

[mircea-c]

@LucasSte that works. I've added the line to the manifest.

[mergify]

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

[mircea-c]

I think this is ready to go. I've sorted the dependencies and the publish simulator passes with this change.

[steviez]

Assuming CI passes,

[steviez]

I got the following warning building the tip of master:

warning: /home/sol/src/agave/svm/Cargo.toml: Found `debug_assertions` in `target.'cfg(...)'.dependencies`. This value is not supported for selecting dependencies and will not work as expected. To learn more visit https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#platform-specific-dependencies

Looking up the docs here:

Unlike in your Rust source code, you cannot use [target.'cfg(feature = "fancy-feature")'.dependencies] to add dependencies based on optional features. Use the [features] section instead:
...
The same applies to cfg(debug_assertions), cfg(test) and cfg(proc_macro). These values will not work as expected and will always have the default value returned by rustc --print=cfg. There is currently no way to add dependencies based on these configuration values.

[mircea-c]

@steviez was this when trying to build? Why did CI pass 😅 ?

[steviez]

@steviez was this when trying to build? Why did CI pass 😅 ?

It was just a warning, we've discussed failing for warnings previously but not actually in there right now.

If you checkout tip-of-master and just run cargo build for any crate, you should see it at the top (ie before any new crates are downloaded)

[mircea-c]

K, I got the same warning when trying to build. I'll submit a new PR which reverts this change and instead adds the feature to the dep.

From that warning message and what I could find in the rust docs, that target simply does nothing.