ci: use cargo sort v2#6406
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6406 +/- ##
=======================================
Coverage 82.8% 82.8%
=======================================
Files 848 848
Lines 379479 379479
=======================================
+ Hits 314461 314482 +21
+ Misses 65018 64997 -21 🚀 New features to boost your workflow:
|
|
looks great, thanks! can we hold for #6351? it'll be easier to rerun |
|
just landed #6351 |
|
@mergify rebase |
❌ Base branch update has failedDetails
|
|
@mergify rebase |
❌ Base branch update has failedDetails
|
|
here's the conflict resolution. can't push to your remote diff --git a/Cargo.toml b/Cargo.toml
index a8cb66321b..bd2265b1a1 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -1,22 +1,3 @@
-<<<<<<< HEAD
-[profile.release-with-debug]
-inherits = "release"
-debug = true
-strip = false
-split-debuginfo = "off"
-
-[profile.release]
-split-debuginfo = "unpacked"
-lto = "thin"
-
-[profile.release-with-lto]
-inherits = "release"
-split-debuginfo = "unpacked"
-lto = "thin"
-codegen-units = 1
-=======
->>>>>>> 482ba4f4eb (cargo sort)
-
[workspace]
members = [
"account-decoder",
@@ -630,11 +611,12 @@ x509-parser = "0.14.0"
# See "zeroize versioning issues" below if you are updating this version.
zeroize = { version = "1.7", default-features = false }
zstd = "0.13.3"
+
[profile.release-with-debug]
inherits = "release"
debug = true
-split-debuginfo = "packed"
-lto = false # Preserve the 'thin local LTO' for this build.
+strip = false
+split-debuginfo = "off"
[profile.release]
split-debuginfo = "unpacked" |
|
Update the readme with the new dependency and instructions? |
|
@sakridge I’m not aware that we document any cargo sort info in our codebase. when you get a chance, could you point me to where that's mentioned. btw, I think it's like an improvement. we can address in a separate PR 🫡 |
* ci: install cargo-sort v2 * cargo sort
* ci: install cargo-sort v2 * cargo sort
Problem
context: https://discord.com/channels/428295358100013066/560503042458517505/1379599822767788043
cargo sort v2 was released ~2 weeks ago and does a decent job at sorting
Summary of Changes
./scripts/cargo-for-all-lock-files.sh -- sort --workspaceand commit