Add LTO flag for cargo-build-sbf#6384
Merged
LucasSte merged 3 commits intoanza-xyz:masterfrom Jun 6, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6384 +/- ##
=========================================
- Coverage 82.8% 82.8% -0.1%
=========================================
Files 849 849
Lines 378935 378935
=========================================
- Hits 313867 313846 -21
- Misses 65068 65089 +21 🚀 New features to boost your workflow:
|
Lichtso
previously approved these changes
Jun 3, 2025
febo
reviewed
Jun 3, 2025
illia-bobyr
reviewed
Jun 4, 2025
Co-authored-by: Fernando Otero <febo@anza.xyz>
illia-bobyr
previously approved these changes
Jun 5, 2025
illia-bobyr
left a comment
illia-bobyr
left a comment
There was a problem hiding this comment.
If you do not want to add a comment on the default value, I think the change is good.
illia-bobyr
approved these changes
Jun 6, 2025
mircea-c
pushed a commit
to mircea-c/agave
that referenced
this pull request
Jun 12, 2025
* Add LTO flag for cargo-build-sbf * Update platform-tools-sdk/cargo-build-sbf/src/main.rs Co-authored-by: Fernando Otero <febo@anza.xyz> * Update lto help descrption --------- Co-authored-by: Fernando Otero <febo@anza.xyz>
mircea-c
added a commit
to mircea-c/agave
that referenced
this pull request
Jun 12, 2025
* Add LTO flag for cargo-build-sbf * Update platform-tools-sdk/cargo-build-sbf/src/main.rs Co-authored-by: Fernando Otero <febo@anza.xyz> * Update lto help descrption --------- Co-authored-by: Fernando Otero <febo@anza.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When anza-xyz/solana-sdk#138 is finally merged, we'll be able to use LTO with programs that include the program and the SDK onmicrates. The usage of LTO for all crates is a little shady in cargo, so I'm adding a flag to
cargo-build-sbfspecially to signal it.Summary of Changes
--ltocommand line argument forcargo-build-sbf.