Add missing features to banks-client crate deps#6445
Add missing features to banks-client crate deps#6445mircea-c merged 1 commit intoanza-xyz:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6445 +/- ##
=========================================
- Coverage 82.8% 82.8% -0.1%
=========================================
Files 848 848
Lines 379479 379479
=========================================
- Hits 314588 314388 -200
- Misses 64891 65091 +200 🚀 New features to boost your workflow:
|
steviez
left a comment
There was a problem hiding this comment.
For the sake of leaving a nice papertrail, here are the specific errors that motivated this change:
Compiling solana-banks-client v2.3.0 (/solana/target/package/solana-banks-client-2.3.0)
error[E0432]: unresolved imports `solana_account::from_account`, `solana_sysvar::Sysvar`
--> src/lib.rs:15:22
|
15 | solana_account::{from_account, Account},
| ^^^^^^^^^^^^ no `from_account` in the root
...
28 | solana_sysvar::Sysvar,
| ^^^^^^^^^^^^^^^^^^^^^ no `Sysvar` in the root
|
note: found an item that was configured out
--> /usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/solana-account-2.2.1/src/lib.rs:756:8
|
756 | pub fn from_account<S: Sysvar, T: ReadableAccount>(account: &T) -> Option<S> {
| ^^^^^^^^^^^^
note: the item is gated behind the `bincode` feature
--> /usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/solana-account-2.2.1/src/lib.rs:754:7
|
754 | #[cfg(feature = "bincode")]
| ^^^^^^^^^^^^^^^^^^^
note: found an item that was configured out
--> /usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/solana-sysvar-2.2.2/src/lib.rs:150:11
|
150 | pub trait Sysvar:
| ^^^^^^
note: the item is gated behind the `bincode` feature
--> /usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/solana-sysvar-2.2.2/src/lib.rs:148:7
|
148 | #[cfg(feature = "bincode")]
| ^^^^^^^^^^^^^^^^^^^
For any subsequent PR's like this, would you mind posting the error output like this ? Helpful incase we encounter something similar down the road and are wondering what/why we did something ?
This one LGTM to me tho!
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
add missing features to banks-client crate (cherry picked from commit bfebc57)
add missing features to banks-client crate
add missing features to banks-client crate
Problem
Crate fails to publish because of missing dependency features
Summary of Changes
Add
bincodefeature to the dependencies that require it.Required to fix CI for #6332