Skip to content

Add missing features to banks-client crate deps#6445

Merged
mircea-c merged 1 commit intoanza-xyz:masterfrom
mircea-c:mc/banks-client-feature-fix
Jun 6, 2025
Merged

Add missing features to banks-client crate deps#6445
mircea-c merged 1 commit intoanza-xyz:masterfrom
mircea-c:mc/banks-client-feature-fix

Conversation

@mircea-c
Copy link
Copy Markdown

@mircea-c mircea-c commented Jun 6, 2025

Problem

Crate fails to publish because of missing dependency features

Summary of Changes

Add bincode feature to the dependencies that require it.

Required to fix CI for #6332

@mircea-c mircea-c requested a review from steviez June 6, 2025 16:28
@mircea-c mircea-c self-assigned this Jun 6, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.8%. Comparing base (347b25d) to head (bd73e25).
⚠️ Report is 3203 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #6445     +/-   ##
=========================================
- Coverage    82.8%    82.8%   -0.1%     
=========================================
  Files         848      848             
  Lines      379479   379479             
=========================================
- Hits       314588   314388    -200     
- Misses      64891    65091    +200     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of leaving a nice papertrail, here are the specific errors that motivated this change:

   Compiling solana-banks-client v2.3.0 (/solana/target/package/solana-banks-client-2.3.0)
error[E0432]: unresolved imports `solana_account::from_account`, `solana_sysvar::Sysvar`
   --> src/lib.rs:15:22
    |
15  |     solana_account::{from_account, Account},
    |                      ^^^^^^^^^^^^ no `from_account` in the root
...
28  |     solana_sysvar::Sysvar,
    |     ^^^^^^^^^^^^^^^^^^^^^ no `Sysvar` in the root
    |
note: found an item that was configured out
   --> /usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/solana-account-2.2.1/src/lib.rs:756:8
    |
756 | pub fn from_account<S: Sysvar, T: ReadableAccount>(account: &T) -> Option<S> {
    |        ^^^^^^^^^^^^
note: the item is gated behind the `bincode` feature
   --> /usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/solana-account-2.2.1/src/lib.rs:754:7
    |
754 | #[cfg(feature = "bincode")]
    |       ^^^^^^^^^^^^^^^^^^^
note: found an item that was configured out
   --> /usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/solana-sysvar-2.2.2/src/lib.rs:150:11
    |
150 | pub trait Sysvar:
    |           ^^^^^^
note: the item is gated behind the `bincode` feature
   --> /usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/solana-sysvar-2.2.2/src/lib.rs:148:7
    |
148 | #[cfg(feature = "bincode")]
    |       ^^^^^^^^^^^^^^^^^^^

For any subsequent PR's like this, would you mind posting the error output like this ? Helpful incase we encounter something similar down the road and are wondering what/why we did something ?

This one LGTM to me tho!

@mircea-c mircea-c merged commit bfebc57 into anza-xyz:master Jun 6, 2025
36 checks passed
@mircea-c mircea-c deleted the mc/banks-client-feature-fix branch June 6, 2025 17:48
@mircea-c mircea-c added the v2.3 label Jun 6, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented Jun 6, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify Bot pushed a commit that referenced this pull request Jun 6, 2025
add missing features to banks-client crate

(cherry picked from commit bfebc57)
steviez pushed a commit that referenced this pull request Jun 9, 2025
) (#6450)

Add missing features to banks-client crate deps (#6445)

add missing features to banks-client crate

(cherry picked from commit bfebc57)

Co-authored-by: Mircea Colonescu <me_mircea@hotmail.com>
mircea-c added a commit to mircea-c/agave that referenced this pull request Jun 12, 2025
add missing features to banks-client crate
mircea-c added a commit to mircea-c/agave that referenced this pull request Jun 12, 2025
add missing features to banks-client crate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants