runtime: Remove dependency on solana-sdk#6308
Merged
steviez merged 1 commit intoanza-xyz:masterfrom May 27, 2025
Merged
Conversation
steviez
commented
May 23, 2025
Author
steviez
left a comment
There was a problem hiding this comment.
All the changes to add features to crates (like below) were done to resolve compilation errors after removing solana-sdk from Cargo.toml:
- solana-transaction = { workspace = true }
+ solana-transaction = { workspace = true, features = ["verify"] }| // Mainnet-beta accounts that should be considered non-circulating | ||
| solana_sdk_macro::pubkeys!( | ||
| non_circulating_accounts, | ||
| fn non_circulating_accounts() -> Vec<Pubkey> { |
Author
There was a problem hiding this comment.
The macro was generating a function with this signature. We can't use the macro as-is while ripping out solana-sdk since the macro implicitly brings in solana_sdk::pubkey::Pubkey here:
https://github.com/anza-xyz/solana-sdk/blob/1276772ee61fbd1f8a60cfec7cd553aa4f6a55f3/sdk-macro/src/lib.rs#L254-L256
4f7e4ab to
361afa6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6308 +/- ##
=======================================
Coverage 82.7% 82.7%
=======================================
Files 845 845
Lines 377824 377824
=======================================
+ Hits 312782 312810 +28
+ Misses 65042 65014 -28 🚀 New features to boost your workflow:
|
vadorovsky
approved these changes
May 24, 2025
t-nelson
approved these changes
May 27, 2025
Merged
mircea-c
pushed a commit
to mircea-c/agave
that referenced
this pull request
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
solana-runtimecrate still depends onsolana-sdkSummary of Changes
Make the necessary changes to remove it.