Skip to content

runtime: Remove dependency on solana-sdk#6308

Merged
steviez merged 1 commit intoanza-xyz:masterfrom
steviez:rm_moar_sdk6
May 27, 2025
Merged

runtime: Remove dependency on solana-sdk#6308
steviez merged 1 commit intoanza-xyz:masterfrom
steviez:rm_moar_sdk6

Conversation

@steviez
Copy link
Copy Markdown

@steviez steviez commented May 23, 2025

Problem

The solana-runtime crate still depends on solana-sdk

Summary of Changes

Make the necessary changes to remove it.

Copy link
Copy Markdown
Author

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes to add features to crates (like below) were done to resolve compilation errors after removing solana-sdk from Cargo.toml:

- solana-transaction = { workspace = true }
+ solana-transaction = { workspace = true, features = ["verify"] }

Comment thread runtime/src/non_circulating_supply.rs Outdated
// Mainnet-beta accounts that should be considered non-circulating
solana_sdk_macro::pubkeys!(
non_circulating_accounts,
fn non_circulating_accounts() -> Vec<Pubkey> {
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The macro was generating a function with this signature. We can't use the macro as-is while ripping out solana-sdk since the macro implicitly brings in solana_sdk::pubkey::Pubkey here:
https://github.com/anza-xyz/solana-sdk/blob/1276772ee61fbd1f8a60cfec7cd553aa4f6a55f3/sdk-macro/src/lib.rs#L254-L256

@steviez steviez force-pushed the rm_moar_sdk6 branch 4 times, most recently from 4f7e4ab to 361afa6 Compare May 23, 2025 22:41
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.7%. Comparing base (ae8fe77) to head (07dca37).
⚠️ Report is 3318 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6308   +/-   ##
=======================================
  Coverage    82.7%    82.7%           
=======================================
  Files         845      845           
  Lines      377824   377824           
=======================================
+ Hits       312782   312810   +28     
+ Misses      65042    65014   -28     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@steviez steviez requested a review from t-nelson May 27, 2025 01:14
@steviez steviez merged commit fb837be into anza-xyz:master May 27, 2025
58 checks passed
@steviez steviez deleted the rm_moar_sdk6 branch May 27, 2025 19:02
@steviez steviez mentioned this pull request May 27, 2025
mircea-c pushed a commit to mircea-c/agave that referenced this pull request Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants