Skip to content

Add serde feature to banks-interface deps#6433

Merged
mircea-c merged 1 commit intoanza-xyz:masterfrom
mircea-c:mc/banks-interface-feature-fix
Jun 5, 2025
Merged

Add serde feature to banks-interface deps#6433
mircea-c merged 1 commit intoanza-xyz:masterfrom
mircea-c:mc/banks-interface-feature-fix

Conversation

@mircea-c
Copy link
Copy Markdown

@mircea-c mircea-c commented Jun 5, 2025

Problem

Publishing this crate fails because of missing features

Summary of Changes

Add serde feature to the dependencies that require it.

Required to fix CI for #6332

@mircea-c mircea-c requested review from steviez and yihau June 5, 2025 21:11
@mircea-c mircea-c self-assigned this Jun 5, 2025
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.8%. Comparing base (347b25d) to head (fd550d8).

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #6433     +/-   ##
=========================================
- Coverage    82.8%    82.8%   -0.1%     
=========================================
  Files         848      848             
  Lines      379479   379479             
=========================================
- Hits       314588   314443    -145     
- Misses      64891    65036    +145     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mircea-c mircea-c merged commit c098edd into anza-xyz:master Jun 5, 2025
36 checks passed
@mircea-c mircea-c deleted the mc/banks-interface-feature-fix branch June 5, 2025 22:05
@mircea-c mircea-c added the v2.3 label Jun 6, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented Jun 6, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify Bot pushed a commit that referenced this pull request Jun 6, 2025
add serde feature to banks-interface deps

(cherry picked from commit c098edd)
steviez pushed a commit that referenced this pull request Jun 9, 2025
…6452)

Add serde feature to banks-interface deps (#6433)

add serde feature to banks-interface deps

(cherry picked from commit c098edd)

Co-authored-by: Mircea Colonescu <me_mircea@hotmail.com>
mircea-c added a commit to mircea-c/agave that referenced this pull request Jun 12, 2025
add serde feature to banks-interface deps
mircea-c added a commit to mircea-c/agave that referenced this pull request Jun 12, 2025
add serde feature to banks-interface deps
@mircea-c mircea-c added the v2.2 label Jun 13, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented Jun 13, 2025

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

mergify Bot pushed a commit that referenced this pull request Jun 13, 2025
add serde feature to banks-interface deps

(cherry picked from commit c098edd)

# Conflicts:
#	banks-interface/Cargo.toml
steviez pushed a commit that referenced this pull request Jun 14, 2025
…6581)

Add serde feature to banks-interface deps (#6433)

Co-authored-by: Mircea Colonescu <mircea.colonescu@anza.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants