Skip to content

Revert "Support receiving verified transactions from the vortexor (#5321)"#6525

Merged
steviez merged 1 commit intoanza-xyz:masterfrom
steviez:revert_e44c17de4d0
Jun 12, 2025
Merged

Revert "Support receiving verified transactions from the vortexor (#5321)"#6525
steviez merged 1 commit intoanza-xyz:masterfrom
steviez:revert_e44c17de4d0

Conversation

@steviez
Copy link
Copy Markdown

@steviez steviez commented Jun 12, 2025

Problem

We need to publish v2.3 crates. The vortextor-receiver crates is currently marked with publish = false

publish = false

but is used by solana-core (which is published)
solana-vortexor-receiver = { workspace = true }

solana-core depending on a crate that is not published makes it unpublishable.

Summary of Changes

This reverts commit e44c17d (introduced by #5321) in order to unblock releases. Note that only a v2.3 tag will be necessary as the commit that is being backed out is not present in v2.2

@steviez steviez added automerge automerge Merge this Pull Request automatically once CI passes v2.3 labels Jun 12, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented Jun 12, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.8%. Comparing base (a60fedd) to head (f1528df).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #6525    +/-   ##
========================================
  Coverage    82.8%    82.8%            
========================================
  Files         851      849     -2     
  Lines      379898   379617   -281     
========================================
- Hits       314626   314532    -94     
+ Misses      65272    65085   -187     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@steviez steviez merged commit 63cf093 into anza-xyz:master Jun 12, 2025
41 checks passed
@steviez steviez deleted the revert_e44c17de4d0 branch June 12, 2025 04:56
@steviez steviez requested a review from lijunwangs June 12, 2025 04:56
mergify Bot pushed a commit that referenced this pull request Jun 12, 2025
)" (#6525)

The reverted commit introduced the solana-vortexor-receiver crate which
was used by solana-core. solana-vortexor-receiver was not set to
publish which means solana-core cannot be published either. So, back
out solana-vortexor in order to unblock crate publishing

This reverts commit e44c17d

(cherry picked from commit 63cf093)

# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	programs/sbf/Cargo.lock
#	svm/examples/Cargo.lock
#	vortexor-receiver/Cargo.toml
steviez added a commit that referenced this pull request Jun 14, 2025
)" (#6525)

The reverted commit introduced the solana-vortexor-receiver crate which
was used by solana-core. solana-vortexor-receiver was not set to
publish which means solana-core cannot be published either. So, back
out solana-vortexor in order to unblock crate publishing

This reverts commit e44c17d

(cherry picked from commit 63cf093)
steviez added a commit that referenced this pull request Jun 17, 2025
…or (#5321)" (backport of #6525) (#6529)

The reverted commit introduced the solana-vortexor-receiver crate which
was used by solana-core. solana-vortexor-receiver was not set to
publish which means solana-core cannot be published either. So, back
out solana-vortexor in order to unblock crate publishing

This reverts commit e44c17d

(cherry picked from commit 63cf093)

---------

Co-authored-by: steviez <steven@anza.xyz>
lijunwangs added a commit that referenced this pull request Jun 25, 2025
#6542)

* Revert "Revert "Support receiving verified transactions from the vortexor (#5321)" (#6525)"

This reverts commit 63cf093.

* publish vortexor-receiver as it is used by core

* Rename solana-vortexor-receiver to agave-verified-packet-receiver

* Missed Cargo.lock update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge automerge Merge this Pull Request automatically once CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants