Ensure that product icons are packaged#1587
Merged
imobachgs merged 1 commit intoagama-project:masterfrom Sep 6, 2024
lkocman:product_icons
Merged
Ensure that product icons are packaged#1587imobachgs merged 1 commit intoagama-project:masterfrom lkocman:product_icons
imobachgs merged 1 commit intoagama-project:masterfrom
lkocman:product_icons
Conversation
imobachgs
approved these changes
Sep 6, 2024
Contributor
|
I overlooked this pull request and had created an identical patch to fix the issue :-) Thank you! |
Contributor
|
We need to think a little bit about this, because IMHO the logos could be included in the products package (where they are mentioned). But, by now, it is good enough. |
imobachgs
added a commit
that referenced
this pull request
Sep 6, 2024
) The logos/ directory is already inside web_ui/. ## Problem Latest agama-web-ui [is not building](https://build.opensuse.org/package/live_build_log/systemsmanagement:Agama:Devel/agama-web-ui/openSUSE_Tumbleweed/x86_64) after #1587 . ## Solution Since the logos are already installed in `web_ui/logos`, we can drop the two (non-existent)? directories listed in the %files section: ``` %{_datadir}/agama/assets %{_datadir}/agama/products ``` ## Testing - *Tested manually*
Contributor
My fault @lkocman I don't know why I chosen the latest while working on #1550
Agree. The product package should be responsible of placing its assets in the web_ui assets directory instead of adding them one by one to the web client build. We should work on defining it. |
Merged
imobachgs
added a commit
that referenced
this pull request
Sep 20, 2024
Prepare for releasing Agama 10· * #1263 * #1330 * #1407 * #1408 * #1410 * #1411 * #1412 * #1416 * #1417 * #1419 * #1420 * #1421 * #1422 * #1423 * #1424 * #1425 * #1428 * #1429 * #1430 * #1431 * #1432 * #1433 * #1436 * #1437 * #1438 * #1439 * #1440 * #1441 * #1443 * #1444 * #1445 * #1449 * #1450 * #1451 * #1452 * #1453 * #1454 * #1455 * #1456 * #1457 * #1459 * #1460 * #1462 * #1464 * #1465 * #1466 * #1467 * #1468 * #1469 * #1470 * #1471 * #1472 * #1473 * #1475 * #1476 * #1477 * #1478 * #1479 * #1480 * #1481 * #1482 * #1483 * #1484 * #1485 * #1486 * #1487 * #1488 * #1489 * #1491 * #1492 * #1493 * #1494 * #1496 * #1497 * #1498 * #1499 * #1500 * #1501 * #1502 * #1503 * #1504 * #1505 * #1506 * #1507 * #1508 * #1510 * #1511 * #1512 * #1513 * #1514 * #1515 * #1516 * #1517 * #1518 * #1519 * #1520 * #1522 * #1523 * #1524 * #1525 * #1526 * #1527 * #1528 * #1529 * #1530 * #1531 * #1532 * #1533 * #1534 * #1535 * #1536 * #1537 * #1540 * #1541 * #1543 * #1544 * #1545 * #1546 * #1547 * #1548 * #1549 * #1550 * #1552 * #1553 * #1554 * #1555 * #1556 * #1557 * #1558 * #1559 * #1560 * #1562 * #1563 * #1565 * #1566 * #1567 * #1568 * #1569 * #1570 * #1571 * #1572 * #1573 * #1574 * #1575 * #1576 * #1577 * #1578 * #1579 * #1580 * #1581 * #1583 * #1584 * #1585 * #1586 * #1587 * #1588 * #1589 * #1590 * #1591 * #1592 * #1593 * #1596 * #1597 * #1598 * #1600 * #1602 * #1605 * #1606 * #1607 * #1608 * #1610 * #1611 * #1612 * #1613 * #1614 * #1619 * #1620 * #1621
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello folks
Here's a fix that ensures installation of missing product icons but I'm not really happy about two things.
It seems that we're somehow trying to webpack this (I don't really have experience with this) I know that we're doing some npm installation in spec so I'm not sure if we should fix the webpack instead.
Why do we have it in src/assets/products/.svg and install it into assets/logos/.svg ?
Let's just use same path in both cases.
Cheers